Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: demo with nextcloud support #7698

Merged
merged 3 commits into from
Nov 23, 2023
Merged

wip: demo with nextcloud support #7698

merged 3 commits into from
Nov 23, 2023

Conversation

caolanm
Copy link
Contributor

@caolanm caolanm commented Nov 21, 2023

  • Resolves: #
  • Target version: master

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

@caolanm
hack to get this up and working
a6eb3a9 
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I6d3d273f59f58a0c3b2027039dcc7de95ad971b9
@caolanm caolanm marked this pull request as draft November 21, 2023 21:08
@caolanm
Copy link
Contributor Author

caolanm commented Nov 21, 2023

Just stashing this here:

@Ashod
This appears to work with a daily nextcloud snapshot with git trunk richdocuments installed (so nextcloud/server#38082 is already applied) and nextcloud/richdocuments#3260 manually applied with the commented out lines restored.

@caolanm
we want %ACCESS_TOKEN%, etc to exist for wasm
cbfe027 
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I58f187c28c158e80fbe97290bb802b3481a44de9
@caolanm
need this even if we want to not serve wasm if the headers exist in r…
f648d4d 
…ichdocuments

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I310894e5a72002406eff77b07af76c2b048ffacc
@caolanm caolanm force-pushed the private/caolanm/wasm_demo_with_nextcloud branch from 1c23384 to f648d4d Compare November 22, 2023 11:43
Ashod
Ashod approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@Ashod Ashod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @caolanm.

@caolanm caolanm marked this pull request as ready for review November 23, 2023 12:53
@caolanm caolanm merged commit 7a21ab2 into private/ash/demo Nov 23, 2023
3 checks passed
@caolanm caolanm deleted the private/caolanm/wasm_demo_with_nextcloud branch November 23, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashod Ashod Ashod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Collabora Online
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caolanm @Ashod