Shortcuts-bar remove menubar #4279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The |
|
nice, we can also remove widget implementation for that menu: |
all commands from menubar was added to the notebookbar so no need for the hamburger menubar button Signed-off-by: andreas kainz <kainz.a@gmail.com> Change-Id: Icb283b40c269d2f92a29ad16dba8dda9d0f860d2
Andreas-Kainz
force-pushed
the
private/Andreas-Kainz/ShortcutsBar
branch
from
93b9763
to
f3e006a
Compare
pedropintosilva
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all commands from menubar was added to the notebookbar
so no need for the hamburger menubar button
Signed-off-by: andreas kainz kainz.a@gmail.com
Change-Id: Icb283b40c269d2f92a29ad16dba8dda9d0f860d2
I didn't remove the code from getShortcutsBarData cause there are 3rd party apps that use this Shortcuts-bar to add there commands there.
@pedropintosilva I checked all commands. All commands are available somewhere else. So it's possible to hide the hamburger menubar button.