Update types.py to fix issues with 'bad cast' RPCError #101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like someone started transitioning the RPC messages to be array based instead of dict based but they didn't finish the job.
I haven't verified that all the types match between
types.py
and the structures defined inRpcLibAdaptorsBase.hpp
, but I found at least one error inImageResponse
(missing the newcamera_name
attribute) so there very well could be others.Fixes: #100
Fixes: #99
About
See above
These changes also break backwards compatibility with the
pip install airsim
library. I'd recommend registering a newcodexairsim
plugin with pip and making use of theServerVersion
andClientVersion
properties.There's another
airsim
fork by Cosys (https://github.com/Cosys-Lab/Cosys-AirSim), which also works with 5.4 and adds some new features, but for me it breaks other things. Might be helpful to someone.How Has This Been Tested?
Tested locally. If you want to use this, you'll need to copy the
PythonClient\airsim
files and overwrite the files you installed viapip install airsim
Screenshots (if appropriate):