Potential Buffer Overflow

[tay10r]

Colosseum/AirLib/src/common/common_utils/FileSystem.cpp

Line 105 in 2383b0a

if (0 < GetModuleFileName(hModule, szPath, sizeof(szPath))) {

The third parameter expresses the buffer being larger than it actually is, since the size of wchar_t is greater than 1.

The function documentation is here.

https://learn.microsoft.com/en-us/windows/win32/api/libloaderapi/nf-libloaderapi-getmodulefilenamea

The docs mention that the third parameter is the size of the buffer in terms of TCHARS.
Which means that it is more of an element count, than a byte count.
I believe it should be set to MAX_PATH.