Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge certain effects across voices (e.g. let ring & palm mute) #1221

Open
Danielku15 opened this issue Jul 11, 2023 · 1 comment
Open

Merge certain effects across voices (e.g. let ring & palm mute) #1221

Danielku15 opened this issue Jul 11, 2023 · 1 comment
Assignees
@Danielku15
Labels
area-rendering Everything related to the rendering platform-all Affects all platforms state-accepted This is a valid topic to work on. type-improvement 🚀

Comments

@Danielku15
Copy link
Member

Currently alphaTab renders the effects like let ring and palm mute individually per each voice. While this is not correct, it rather bloats the music sheet. Guitar Pro 7 and 8 also merge those effects across voices to be shown only once.

image

image

Additionally I noticed with this example that let ring doesn't expand on tied notes which seem to be the case in GP7 and GP8. Might be a bug. We should extend line effects like this to tied notes.
@Danielku15 Danielku15 added type-improvement 🚀 area-rendering Everything related to the rendering state-accepted This is a valid topic to work on. platform-all Affects all platforms labels Jul 11, 2023
@Danielku15 Danielku15 self-assigned this May 14, 2024
@Danielku15
Copy link
Member Author

Maybe in the same step we can also adapt how "effect slots" are reused. Guitar Pro seems to keep it simple and only extend a slot reservation if the effect is really spanning across bars without interruption. This would allow a lot more condensed notation in case of horizontal layouts

alphaTab:

Image

Guitar Pro:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Danielku15 Danielku15

Labels
area-rendering Everything related to the rendering platform-all Affects all platforms state-accepted This is a valid topic to work on. type-improvement 🚀
Projects
alphaTab 1.4-1.x
Status: Candidate
alphaTab Roadmap
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Danielku15