New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the screensaver code #13

Open

roughike opened this issue Dec 20, 2016 · 0 comments

Labels

Test Coverage User Experience

Contributor

roughike commented Dec 20, 2016 •

edited

Loading

The active times are hardcoded inside the class. Maybe make a setting in the app settings for the user to choose the active times themselves.
It has no tests at all. Although the start(), stop() and defer() method calls are probably the most important to test.defer() is the MainPresenter's responsibility, while the others would be tested in the Activity test class.

The text was updated successfully, but these errors were encountered:

roughike self-assigned this

roughike added the Uncle Bob Would Approve label

roughike changed the title ~~Refactor the screensaver code~~ Various code quality improvements

roughike changed the title ~~Various code quality improvements~~ Refactor the screensaver code

roughike added User Experience Test Coverage and removed Uncle Bob Would Approve labels

roughike removed their assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment