Fix Factory compatibility issue with Lumen < 7 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With illuminate/database version 7 Factory names are removed - more info laravel/framework#30867 Checking for property `name` ensures that this parameter can be passed.
|
Hey, could someone take a look at this Merge request as most of out tests are failing? |
TavoNiievez
approved these changes
Apr 29, 2021
There was a problem hiding this comment.
@ibpavlov Sorry for the delay, apparently I was not subscribed to the module, and therefore I was not notified of your PR.
Looks good to me.
|
I released your change as |
Thank you too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With illuminate/database version 7 Factory names are removed - more info laravel/framework#30867
Checking for property
nameensures that this parameter can be passed.