Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO: refactor place_closer_order allow_partial #588

Closed
bitphage opened this issue May 12, 2019 · 2 comments
Closed

SO: refactor place_closer_order allow_partial #588

bitphage opened this issue May 12, 2019 · 2 comments
Labels
[3] Type: Bug [5] Medium Task Indicates size of task. Est. between two and five hours

Comments

@bitphage
Copy link
Collaborator

When cancelling a dust order and placing closer opposite order need to set own asset limiter to avail balance. allow_partial=True doesn't solves the problem when sides are massively imbalanced because allow_partial=True still has a soft limit.

Tets failing: test_allocate_asset_dust_order()

@bitphage bitphage added [3] Type: Bug [5] Small Task Indicates size of task. Est. between one and two hours labels May 12, 2019
@bitphage
Copy link
Collaborator Author

Also when placing closer order when only one order needed to reach target spread, allow_partial=True also used. Probably need to remove soft limit imposed by allow_partial=True: balance > order['base']['amount'] * self.partial_fill_threshold), and probably remove bundling when bootstrap is off.

@bitphage bitphage changed the title SO: dust order cancel bug SO: refactor place_closer_order allow_partial May 15, 2019
@bitphage
Copy link
Collaborator Author

test_allocate_asset_dust_order() is no longer indicates an issue, a separate test should be written.

@bitphage bitphage added [5] Medium Task Indicates size of task. Est. between two and five hours and removed [5] Small Task Indicates size of task. Est. between one and two hours labels Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[3] Type: Bug [5] Medium Task Indicates size of task. Est. between two and five hours
Projects
None yet
Development

No branches or pull requests

1 participant