Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvol support for `git branch <newbranch>' #3

Open
wallnerryan opened this issue Nov 12, 2015 · 1 comment
Open

dvol support for `git branch <newbranch>' #3

wallnerryan opened this issue Nov 12, 2015 · 1 comment

Comments

@wallnerryan
Copy link

This is the error

-> dvol branch hiagain
Wrong number of arguments.

Expected behavior

-> dvol branch hiagain
->
@lukemarsden
Copy link
Contributor

To be clear, you'd expect this to make a new branch from current branch's HEAD but not check it out?

Should be simple to add this, https://github.com/ClusterHQ/dvol/blob/master/voluminous/dvol.py#L438

add a parseArgs

def parseArgs(self, branch=None):
        self.branch = branch

then factor out https://github.com/ClusterHQ/dvol/blob/master/voluminous/dvol.py#L121 into a new function createBranch

then add to run something like

    if self.branch is not None:
        self.voluminous.createBranch(...)

anyone fancy picking this up as low hanging fruit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants