Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

looks_like field requirement #61285

Closed
secretstamos opened this issue Sep 26, 2022 · 3 comments
Closed

looks_like field requirement #61285

secretstamos opened this issue Sep 26, 2022 · 3 comments
Labels
Code: Tests Measurement, self-control, statistics, balancing. [JSON] Changes (can be) made in JSON Organization General development organization issues SDL: Tiles / Sound Tiles visual interface and sounds. stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing

Comments

@secretstamos
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I believe there should be a mandate for looks_like for all new content (items/monster/terrain/furniture) in the main repo.

It takes significantly less development time for the developer adding the item/monster/ect to fill out this field than it does for every tileset to both identify the missing icon and add it.

At least in my own experience this is the largest loss of efficiency.

Solution you would like.

Require the looks_like field for all new additions

Describe alternatives you have considered.

Fris mentioned adding a CI check for it instead/in addition, which is an idea I like

Additional context

I started the Hollow Moon tileset
This also affects new tilesets, not just the existing ones

@secretstamos secretstamos added the <Suggestion / Discussion> Talk it out before implementing label Sep 26, 2022
@Fris0uman
Copy link
Contributor

Having a workflow that warns, but don't fail tests, if a new entity is added without looks_like would be nice. Something a bit like the dictionnary spelling check thing, that will remind you to set it up but that you can ignore in the cases where it doesn't make sense

@secretstamos
Copy link
Contributor Author

Having a workflow that warns, but don't fail tests, if a new entity is added without looks_like would be nice. Something a bit like the dictionnary spelling check thing, that will remind you to set it up but that you can ignore in the cases where it doesn't make sense

Yeah I agree, so long as it isn't something that gets ignored in practice

@Fris0uman Fris0uman added [JSON] Changes (can be) made in JSON Organization General development organization issues SDL: Tiles / Sound Tiles visual interface and sounds. Code: Tests Measurement, self-control, statistics, balancing. labels Sep 26, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Jan 30, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Tests Measurement, self-control, statistics, balancing. [JSON] Changes (can be) made in JSON Organization General development organization issues SDL: Tiles / Sound Tiles visual interface and sounds. stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

2 participants