Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing env #259

Closed
wants to merge 2 commits into from
Closed

Conversation

yeelauren
Copy link

Hey friends!
While testing locally, I noticed that the environment.yml file seems to be missing some packages for the notebooks in /docs.
I've made my attempt at fixing the version numbers.

I also noticed that this repo is missing a reference to the submodule stacchip

"from stacchip.processors.prechip import normalize_timestamp\n",

To get this to run locally, I had to copy and move the directory around for stacchip.

@yellowcap yellowcap requested a review from weiji14 June 3, 2024 17:31
@yellowcap
Copy link
Member

Not sure if we should also update the conda-lock.yml file with this?

Copy link
Contributor

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yeelauren! Thanks for opening this, the conda environment definitely needs an update with all the recent changes. Could you refresh the conda-lock.yml file as @yellowcap mentioned after adding stacchip (see suggestion below)? You can do this by following the instructions at https://clay-foundation.github.io/model/installation.html#advanced, i.e. run:

conda-lock lock --mamba --file environment.yml --with-cuda=12.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed that this repo is missing a reference to the submodule stacchip

Yes, could you add the following lines (copied from #211) to the environment.yml file:

  - pip
  - pip:
     - https://github.com/Clay-foundation/stacchip/archive/refs/tags/0.1.30.zip

@yellowcap, just confirming that it's v0.1.30 that we want here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stacchip is pip installable now 😄 https://pypi.org/project/stacchip/ So the addition should read

  - pip
  - pip:
     - stacchip==0.1.30

@yellowcap
Copy link
Member

yellowcap commented Jun 5, 2024

We removed the stacchip library from the dependencies, as it was only used in one notebook for one tiny function. The updated wall-to-wall notebook is now independent of stacchip.

I think with this also the geoarrow and boto3 dependencues are no longer necessary. @yeelauren when you have time, please test your workflow again using main or the branch and let us know if the dependency issues were resolved.

Btw, we are also updating other libraries on the env file in #264

@yellowcap
Copy link
Member

I think this has been fixed in updating the env here #264 and removing stacchip from the wall-to-wall example here #263.

@yeelauren feel free to reopen if you still encounter these problems.

@yellowcap yellowcap closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants