-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add osx-arm64 platform to conda-lock.yml file and GitHub Actions CI #164
Merged
Merged
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
05e0364
:pushpin: Add osx-arm64 platform to conda-lock.yml file
weiji14 1cbf311
:construction_worker: Add macos-14 to GitHub Actions CI test matrix
weiji14 af53ab4
:twisted_rightwards_arrows: Merge branch 'main' into ci/osx-arm64
weiji14 efb568b
:wrench: Set PYTORCH_MPS_HIGH_WATERMARK_RATIO=0.0
weiji14 9069449
:wrench: Try setting PYTORCH_MPS_PREFER_METAL=0
weiji14 8ebbd31
Exclude conda-lock.yml from pre-commit check-added-large-files
weiji14 ea52a3b
:green_heart: Fallback to CPU on MPS when PYTORCH_MPS_PREFER_METAL=0
weiji14 2119c6e
:loud_sound: Debug output of torch.backends.mps.is_available()
weiji14 cbb30db
:label: Check that PYTORCH_MPS_PREFER_METAL matches str(0), not 0
weiji14 a0854fd
Merge branch 'main' into ci/osx-arm64
weiji14 7451104
Reword comment on why MPS is disable on macos-14 runner
weiji14 70b2075
:memo: Update installation instructions for macOS users
weiji14 bb3a3e7
:ambulance: Quickfix note admonition on main README.md
weiji14 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This disables MPS for all platforms in the matrix. Is that what you want, or do you want to disable it only for macos-14?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MPS is only available on macos-14, and I've added an if-condition in the unit tests to only disable MPS on devices with MPS, so should be ok? Open to a better way of doing things though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. I suppose the comment may have thrown me off. Here, "doesn't work" doesn't mean that we can't choose to use it, but rather that when we do choose to use it, the test fails due to running out of memory. So it would work if we had enough memory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, maybe I can reword it a little bit, how about this:
We disable MPS because it runs out of memory (or rather, it doesn't allow allocating GPU-like MPS memory?) on the
macos-14
GitHub Actions runner as mentioned at actions/runner-images#9254 (comment).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, reworded at 7451104