Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuffle patches only during training #135

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

yellowcap
Copy link
Member

This removes the shuffle argument and shuffles patches only during training. Closes #123

This removes the shuffle argument and shuffles patches only during training.
Closes #123
Copy link
Collaborator

@srmsoumya srmsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to not shuffle the patches by default.

@yellowcap yellowcap merged commit ae70345 into main Jan 25, 2024
4 checks passed
@yellowcap yellowcap deleted the shuffle-on-training-only branch January 25, 2024 15:48
yellowcap added a commit that referenced this pull request Jan 26, 2024
No longer necessary after #135
yellowcap added a commit that referenced this pull request Jan 26, 2024
No longer necessary after #135
yellowcap added a commit that referenced this pull request Jan 29, 2024
* Add option to output raw patch embeddings

The patch embeddings are averages over the band groups.

* Fix test parametrization

* Fix test litmodel extra args only for clay

* Fix and improve einops conversion

* Document patch level embedding option

* Fix clay module check in test

* Add shuffle parameter to cli

* Document patch level embedding conversion

* Improve wording on patch level unravelling

* Fix argument construction in embeddigns docs

* Add vscode conf dir to gitignore

* Change embedding handling to level based approach

Allow for 3 levels: mean, patch, group. Arrays are flattened when passed to pandas.
This could be improved in the future.

* Enforce contiguous array before passing to pyarrow

* Remove shuffle argument

No longer necessary after #135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable patch shuffling by default
2 participants