-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/SDK/notebooks with nbdev [try 2] #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
After thinking about it, I'll spin out this folder with documentation to a new repository. Spinning out on https://github.com/Clay-foundation/documentation/pull/1 |
brunosan
added a commit
that referenced
this pull request
Dec 28, 2023
We are spinning out the documentation to a separate repo. This cleans up the workflow. See #103 (comment)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This take into account some of @weiji14 comments on #102 (which I abandoned to not deal with a polluted git history).
I will not spend much time on the architecture (nbdev vs other options). I do like the option to have all 3 assets at once (documentation htmls, SDK and notebooks) but I understand
nbdev
might be too rare on stale.I'll focus meanwhile on the notebooks themselves and we can port the content to other tools.
In the end we need documentation asap.