Update GitHub Actions versions and module options in sanity_tests.yml…

… and reservation.py
CiscoISE · Jul 20, 2024 · 2335453 · 2335453
1 parent d55c1d4
commit 2335453
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 15 deletions.
diff --git a/.github/workflows/sanity_tests.yml b/.github/workflows/sanity_tests.yml
@@ -5,6 +5,7 @@ on:
   pull_request:
   schedule:
     - cron: '0 6 * * *'
+  workflow_dispatch:
 env:
   NAMESPACE: cisco
   COLLECTION_NAME: ise 
@@ -21,15 +22,15 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - name: Check out code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           path: CiscoISE/ansible-ise
       - name: Create directory
         run: mkdir -p ./ansible_collections/${{env.NAMESPACE}}
       - name: Move repository
         run: mv ./CiscoISE/ansible-ise ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}}
       - name: Set up Python
-        uses: actions/setup-python@v3
+        uses: actions/setup-python@v5
         with:
           python-version: '3.11'
       - name: Install ansible-base (${{ matrix.ansible }})

diff --git a/plugins/modules/reservation.py b/plugins/modules/reservation.py
@@ -21,9 +21,6 @@
   clientID:
     description: ClientID path parameter. Unique name for a Client.
     type: str
-  clientId:
-    description: Unique ID of the given client.
-    type: str
   clientName:
     description: Name of the given client.
     type: str
@@ -71,7 +68,6 @@
     ise_verify: "{{ise_verify}}"
     state: present
     clientID: string
-    clientId: string
     endIndex: 0
     startIndex: 0
 
@@ -93,7 +89,7 @@
   type: dict
   sample: >
     {
-      "clientId": "string",
+      "clientID": "string",
       "clientName": "string",
       "endIndex": 0,
       "startIndex": 0

diff --git a/plugins/modules/support_bundle_download.py b/plugins/modules/support_bundle_download.py
@@ -22,9 +22,6 @@
   fileName:
     description: Support Bundle Download's fileName.
     type: str
-  filename:
-    description: The filename used to save the download file.
-    type: str
   saveFile:
     description: Enable or disable automatic file creation of raw response.
     type: bool
@@ -48,8 +45,7 @@
     ise_password: "{{ise_password}}"
     ise_verify: "{{ise_verify}}"
     dirPath: /tmp/downloads/
-    fileName: string
-    filename: download_filename.extension
+    fileName: download_filename.extension
     saveFile: true
 
 """
@@ -61,9 +57,9 @@
   type: dict
   sample: >
     {
-      "data": "filecontent",
-      "filename": "filename",
+      "data": "fileContent",
+      "fileName": "fileName",
       "dirpath": "download/directory",
-      "path": "download/directory/filename"
+      "path": "download/directory/fileName"
     }
 """