Hard-burn subtitles #68
Replies: 10 comments 4 replies
-
Hello! |
Beta Was this translation helpful? Give feedback.
-
Just wondering if you'd made any progress. I remain confused, sadly. |
Beta Was this translation helpful? Give feedback.
-
Hello! Still no idea why it doesn't work. |
Beta Was this translation helpful? Give feedback.
-
I'm still at a loss - tried everything I can think of to understand what's misfiring, no joy. Really weird. |
Beta Was this translation helpful? Give feedback.
-
@CineEncoder : did you manage to figure this out? I'm still puzzled, sadly. |
Beta Was this translation helpful? Give feedback.
-
So I've submitted a PR here : #70 This re-works the internals to avoid constructing and then decomposing strings. The old approach was not particularly robust:
Moving to QStringLists gives really convenient separation automatically, and it also allows empty entries to be easily cleaned out. I've also added UI controls for hard-burn selection of font, color, whether to add a background, background color and background opacity. I've tested most of this and it seems to work, but more testing is welcome. |
Beta Was this translation helpful? Give feedback.
-
Location is also now added, and testing revealed and allowed fixing of various issues. I'm fairly happy with this. I'm tempted to look at the preset system to see if there might be a way to have preset-defined subtitles that could override the preferences definitions, so that both workflows can be accommodated. |
Beta Was this translation helpful? Give feedback.
-
I set up a WIP branch for preset implementation. I am struggling to see how the preset UI is updated based on the preset values at the moment : https://github.com/philstopford/cine-encoder/tree/hardburn_subtitles_presetWIP |
Beta Was this translation helpful? Give feedback.
-
@CineEncoder : some overview / assistance for the preset side of things would be welcome. I'm actually wondering about the design of this system because it seems to need a rebuild each time the preset changes. I wondered whether something around XML would work better rather than what appears to be a binary blob as well. What do you think? |
Beta Was this translation helpful? Give feedback.
-
Just nudging re preset guidance |
Beta Was this translation helpful? Give feedback.
-
So I've been hacking away at this for a while and seem to have run into an odd wall that I don't yet understand. In the PRs I've submitted, it looks like it should be working, but I get an error reported. Printing out the arguments, I can copy and paste them with the installed ffmpeg and the hard-burn works without issue or error:
I can't see the exact nature of the error so far - this is what gets reported from cineencoder itself:
I'm baffled.
The first snippet above is what I get for args_ and runs just fine, as mentioned, if I copy/paste into a terminal and run with ffmpeg.
Any ideas?
Beta Was this translation helpful? Give feedback.
All reactions