Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add riscv64 info and simplify macos #394

Merged
merged 10 commits into from
Sep 7, 2023
Merged

Add riscv64 info and simplify macos #394

merged 10 commits into from
Sep 7, 2023

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Sep 1, 2023

Simplify macos checks by just using CMAKE_SYSTME_PROCESSOR and add in riscv64

hoffmang9
hoffmang9 previously approved these changes Sep 1, 2023
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emlowe emlowe marked this pull request as ready for review September 5, 2023 14:28
cmmarslender
cmmarslender previously approved these changes Sep 7, 2023
.github/workflows/build-test-riscv64.yml Outdated Show resolved Hide resolved
Co-authored-by: Chris Marslender <chrismarslender@gmail.com>
@hoffmang9
Copy link
Member

hoffmang9 commented Sep 7, 2023

BTW: As a person not as conversant in docker as I'd like to be - there may be a better riscv64/debian image and/or it might make more sense for us to cache one that has more python and build tools - but also don't want to make any more work than this fun side project.

@hoffmang9 hoffmang9 merged commit f569a99 into main Sep 7, 2023
32 checks passed
@hoffmang9 hoffmang9 deleted the EL.riscv branch September 7, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants