[CHIA-1067] Integrate coin selection with action scopes #18424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ee_to_push_transactions
github-actions
bot
added
merge_conflict
Quexington
added
Changed
Quexington
changed the base branch from
main
to
quex.wallet_side_effects_streamable
github-actions
bot
removed
the
merge_conflict
github-actions
bot
added
the
merge_conflict
github-actions
bot
removed
the
merge_conflict
geoffwalmsley
approved these changes
Aug 19, 2024
markelrod
approved these changes
Aug 19, 2024
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, each wallet individually selects coins based on the current state of the DB. This means that if you’re attempting to generate multiple transactions that depend on each other at a time, you have to manually edit the action scope’s TX config to indicate what coins are selected.
To avoid this, we move this functionality into the action scope so that selected coins are visible to all future transaction generators. When selected coins are added here, we ignore them when we go to select coins again.