Skip to content
This repository has been archived by the owner on Nov 6, 2019. It is now read-only.

Support version v3 in a separate branch? #36

Open
dejanr opened this issue Feb 20, 2019 · 3 comments
Open

Support version v3 in a separate branch? #36

dejanr opened this issue Feb 20, 2019 · 3 comments

Comments

@dejanr
Copy link

dejanr commented Feb 20, 2019

Hi,

I am currious if you would be willing to support v3 in a separate branch, we have run into retired version warning for google maps, and i am willing to send a patch for new version of old version 3.3.1 if you are interested to support it. In that case we would need a new branch for v3 which is based on version 3.3.1, and i would create a PR for that branch, publishing that version should be possible by using npm publish --tag old-version

@eur2
Copy link

eur2 commented Mar 4, 2019

Hi @dejanr, I'm trying to make working a GoogleMap with react-leaflet-google. It seems not working anymore (I got "retired version" in the console). Did you manage to fix it and make it working?
Many thanks in advance

@dejanr
Copy link
Author

dejanr commented Mar 4, 2019

Hi @grdpr. For version 3 i have created patch version here https://github.com/holidaycheck/react-leaflet-google/tree/v3.3.2 in our fork. For both versions it is probably the same change. In my opinion this VERSION should be exposed and not hard coded.

I am happy to create PR and push this upstream, but let see if @Charmatzis is interested in accepting and publishing this.

@eur2
Copy link

eur2 commented Mar 4, 2019

Thanks! Indeed let's hope to publish it because i can't make it working in the hard coded version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants