Handle block forks

[twoeths]

Goal

• Close Properly handle block forks #578

[codecov]

Codecov Report

Merging #584 into 0.9.x will increase coverage by 0.01%.
The diff coverage is 18.18%.

@@            Coverage Diff            @@
##            0.9.x    #584      +/-   ##
=========================================
+ Coverage   65.49%   65.5%   +0.01%     
=========================================
  Files         198     198              
  Lines        3599    3601       +2     
  Branches      338     337       -1     
=========================================
+ Hits         2357    2359       +2     
  Misses       1138    1138              
  Partials      104     104

[mpetrunic]

Shouldn't we change head state if "applyForkChoice" changes head?

[wemeetagain]

@mpetrunic I think thats what applyForkChoice is doing

[mpetrunic]

@mpetrunic I think thats what applyForkChoice is doing

Yeah but we won't have state for that?

Shouldn't we run state transition from last common state?

[wemeetagain]

applyForkChoice is getting called right after the state transition has been run, and the post state stored in the db.
I think it has everything it needs?

[mpetrunic]

applyForkChoice is getting called right after the state transition has been run, and the post state stored in the db.
I think it has everything it needs?

Thsi works for:

block A -----> block B
         \
          \
           \
            \
             > block C

but what if we have:

block A-----> B -----> block C
         \
          \
            > B1-------->C1

I guess we don't have to support that scenario yet?