Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parse bootnode entires with IP and location information #5834

Merged
merged 3 commits into from
Aug 1, 2023
Merged

fix: parse bootnode entires with IP and location information #5834

merged 3 commits into from
Aug 1, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Aug 1, 2023

Motivation

Closes #5833

Description

  • Fix parsing of bootnode entires with IP and location information
  • Update outdated references to --network.discv5.bootEnrs flag
  • Pin genesis and bootnode file URLs by commit hash

@nflaig nflaig requested a review from a team as a code owner August 1, 2023 15:56
@nflaig nflaig changed the title fix: correctly parse bootnode entires with IP and location information fix: parse bootnode entires with IP and location information Aug 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: a5f4e2a Previous: 3ef8a00 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 534.71 us/op 551.91 us/op 0.97
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 79.345 us/op 82.610 us/op 0.96
BLS verify - blst-native 1.2820 ms/op 1.2905 ms/op 0.99
BLS verifyMultipleSignatures 3 - blst-native 2.5956 ms/op 2.8912 ms/op 0.90
BLS verifyMultipleSignatures 8 - blst-native 5.6869 ms/op 5.6144 ms/op 1.01
BLS verifyMultipleSignatures 32 - blst-native 20.607 ms/op 20.334 ms/op 1.01
BLS aggregatePubkeys 32 - blst-native 28.412 us/op 27.864 us/op 1.02
BLS aggregatePubkeys 128 - blst-native 108.88 us/op 106.44 us/op 1.02
getAttestationsForBlock 73.634 ms/op 60.485 ms/op 1.22
isKnown best case - 1 super set check 483.00 ns/op 342.00 ns/op 1.41
isKnown normal case - 2 super set checks 534.00 ns/op 443.00 ns/op 1.21
isKnown worse case - 16 super set checks 437.00 ns/op 405.00 ns/op 1.08
CheckpointStateCache - add get delete 6.1820 us/op 5.7250 us/op 1.08
validate api signedAggregateAndProof - struct 3.2160 ms/op 2.8583 ms/op 1.13
validate gossip signedAggregateAndProof - struct 3.0440 ms/op 2.8822 ms/op 1.06
validate api attestation - struct 1.4379 ms/op 1.3658 ms/op 1.05
validate gossip attestation - struct 1.4459 ms/op 1.4339 ms/op 1.01
pickEth1Vote - no votes 1.5143 ms/op 1.4187 ms/op 1.07
pickEth1Vote - max votes 11.770 ms/op 11.632 ms/op 1.01
pickEth1Vote - Eth1Data hashTreeRoot value x2048 9.8685 ms/op 10.553 ms/op 0.94
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 16.882 ms/op 16.091 ms/op 1.05
pickEth1Vote - Eth1Data fastSerialize value x2048 734.69 us/op 807.16 us/op 0.91
pickEth1Vote - Eth1Data fastSerialize tree x2048 5.8076 ms/op 7.4798 ms/op 0.78
bytes32 toHexString 723.00 ns/op 994.00 ns/op 0.73
bytes32 Buffer.toString(hex) 357.00 ns/op 393.00 ns/op 0.91
bytes32 Buffer.toString(hex) from Uint8Array 612.00 ns/op 627.00 ns/op 0.98
bytes32 Buffer.toString(hex) + 0x 341.00 ns/op 372.00 ns/op 0.92
Object access 1 prop 0.22800 ns/op 0.24300 ns/op 0.94
Map access 1 prop 0.16900 ns/op 0.17600 ns/op 0.96
Object get x1000 8.1180 ns/op 12.025 ns/op 0.68
Map get x1000 0.89600 ns/op 0.81600 ns/op 1.10
Object set x1000 74.504 ns/op 87.609 ns/op 0.85
Map set x1000 53.375 ns/op 65.129 ns/op 0.82
Return object 10000 times 0.28310 ns/op 0.38690 ns/op 0.73
Throw Error 10000 times 4.2162 us/op 5.1091 us/op 0.83
fastMsgIdFn sha256 / 200 bytes 3.5400 us/op 4.5600 us/op 0.78
fastMsgIdFn h32 xxhash / 200 bytes 363.00 ns/op 496.00 ns/op 0.73
fastMsgIdFn h64 xxhash / 200 bytes 415.00 ns/op 504.00 ns/op 0.82
fastMsgIdFn sha256 / 1000 bytes 12.235 us/op 13.335 us/op 0.92
fastMsgIdFn h32 xxhash / 1000 bytes 521.00 ns/op 576.00 ns/op 0.90
fastMsgIdFn h64 xxhash / 1000 bytes 564.00 ns/op 523.00 ns/op 1.08
fastMsgIdFn sha256 / 10000 bytes 109.77 us/op 117.14 us/op 0.94
fastMsgIdFn h32 xxhash / 10000 bytes 2.1640 us/op 2.1540 us/op 1.00
fastMsgIdFn h64 xxhash / 10000 bytes 1.5150 us/op 1.4850 us/op 1.02
enrSubnets - fastDeserialize 64 bits 1.7450 us/op 1.9100 us/op 0.91
enrSubnets - ssz BitVector 64 bits 578.00 ns/op 605.00 ns/op 0.96
enrSubnets - fastDeserialize 4 bits 253.00 ns/op 246.00 ns/op 1.03
enrSubnets - ssz BitVector 4 bits 571.00 ns/op 540.00 ns/op 1.06
prioritizePeers score -10:0 att 32-0.1 sync 2-0 118.05 us/op 124.88 us/op 0.95
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 141.99 us/op 157.05 us/op 0.90
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 190.25 us/op 205.97 us/op 0.92
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 345.98 us/op 375.08 us/op 0.92
prioritizePeers score 0:0 att 64-1 sync 4-1 392.01 us/op 397.52 us/op 0.99
array of 16000 items push then shift 1.6909 us/op 1.6835 us/op 1.00
LinkedList of 16000 items push then shift 10.002 ns/op 9.4560 ns/op 1.06
array of 16000 items push then pop 88.938 ns/op 64.453 ns/op 1.38
LinkedList of 16000 items push then pop 10.133 ns/op 9.5720 ns/op 1.06
array of 24000 items push then shift 2.6274 us/op 2.5477 us/op 1.03
LinkedList of 24000 items push then shift 9.5490 ns/op 9.6040 ns/op 0.99
array of 24000 items push then pop 126.66 ns/op 126.41 ns/op 1.00
LinkedList of 24000 items push then pop 11.643 ns/op 9.3310 ns/op 1.25
intersect bitArray bitLen 8 7.5450 ns/op 7.1750 ns/op 1.05
intersect array and set length 8 110.21 ns/op 100.04 ns/op 1.10
intersect bitArray bitLen 128 41.954 ns/op 38.319 ns/op 1.09
intersect array and set length 128 1.2735 us/op 1.0646 us/op 1.20
bitArray.getTrueBitIndexes() bitLen 128 2.2600 us/op 2.1870 us/op 1.03
bitArray.getTrueBitIndexes() bitLen 248 3.8810 us/op 2.9710 us/op 1.31
bitArray.getTrueBitIndexes() bitLen 512 7.8060 us/op 5.4710 us/op 1.43
Buffer.concat 32 items 1.2250 us/op 1.3950 us/op 0.88
Uint8Array.set 32 items 2.3200 us/op 3.2540 us/op 0.71
transfer serialized Status (84 B) 2.3920 us/op 2.9400 us/op 0.81
copy serialized Status (84 B) 1.9060 us/op 2.0180 us/op 0.94
transfer serialized SignedVoluntaryExit (112 B) 2.6330 us/op 2.7500 us/op 0.96
copy serialized SignedVoluntaryExit (112 B) 2.0670 us/op 2.4800 us/op 0.83
transfer serialized ProposerSlashing (416 B) 2.7730 us/op 2.9650 us/op 0.94
copy serialized ProposerSlashing (416 B) 2.8710 us/op 2.8970 us/op 0.99
transfer serialized Attestation (485 B) 2.9790 us/op 2.9570 us/op 1.01
copy serialized Attestation (485 B) 2.8450 us/op 2.4920 us/op 1.14
transfer serialized AttesterSlashing (33232 B) 2.8440 us/op 2.3910 us/op 1.19
copy serialized AttesterSlashing (33232 B) 9.1650 us/op 7.7400 us/op 1.18
transfer serialized Small SignedBeaconBlock (128000 B) 4.1890 us/op 2.9070 us/op 1.44
copy serialized Small SignedBeaconBlock (128000 B) 25.790 us/op 21.204 us/op 1.22
transfer serialized Avg SignedBeaconBlock (200000 B) 4.9160 us/op 3.8770 us/op 1.27
copy serialized Avg SignedBeaconBlock (200000 B) 47.399 us/op 29.716 us/op 1.60
transfer serialized BlobsSidecar (524380 B) 5.6620 us/op 3.6130 us/op 1.57
copy serialized BlobsSidecar (524380 B) 130.81 us/op 92.626 us/op 1.41
transfer serialized Big SignedBeaconBlock (1000000 B) 6.1790 us/op 3.5300 us/op 1.75
copy serialized Big SignedBeaconBlock (1000000 B) 288.99 us/op 183.00 us/op 1.58
pass gossip attestations to forkchoice per slot 2.5337 ms/op 2.2920 ms/op 1.11
forkChoice updateHead vc 100000 bc 64 eq 0 2.5799 ms/op 2.1496 ms/op 1.20
forkChoice updateHead vc 600000 bc 64 eq 0 16.119 ms/op 12.224 ms/op 1.32
forkChoice updateHead vc 1000000 bc 64 eq 0 20.309 ms/op 19.694 ms/op 1.03
forkChoice updateHead vc 600000 bc 320 eq 0 23.791 ms/op 17.141 ms/op 1.39
forkChoice updateHead vc 600000 bc 1200 eq 0 100.96 ms/op 90.381 ms/op 1.12
forkChoice updateHead vc 600000 bc 64 eq 1000 20.995 ms/op 22.664 ms/op 0.93
forkChoice updateHead vc 600000 bc 64 eq 10000 24.082 ms/op 24.953 ms/op 0.97
forkChoice updateHead vc 600000 bc 64 eq 300000 60.820 ms/op 39.138 ms/op 1.55
computeDeltas 3.6923 ms/op 3.3125 ms/op 1.11
computeProposerBoostScoreFromBalances 434.16 us/op 411.34 us/op 1.06
altair processAttestation - 250000 vs - 7PWei normalcase 3.1829 ms/op 4.1004 ms/op 0.78
altair processAttestation - 250000 vs - 7PWei worstcase 4.7213 ms/op 5.0443 ms/op 0.94
altair processAttestation - setStatus - 1/6 committees join 201.36 us/op 166.63 us/op 1.21
altair processAttestation - setStatus - 1/3 committees join 377.38 us/op 305.75 us/op 1.23
altair processAttestation - setStatus - 1/2 committees join 525.68 us/op 409.94 us/op 1.28
altair processAttestation - setStatus - 2/3 committees join 639.64 us/op 512.31 us/op 1.25
altair processAttestation - setStatus - 4/5 committees join 857.77 us/op 700.38 us/op 1.22
altair processAttestation - setStatus - 100% committees join 1.0452 ms/op 840.10 us/op 1.24
altair processBlock - 250000 vs - 7PWei normalcase 10.486 ms/op 10.479 ms/op 1.00
altair processBlock - 250000 vs - 7PWei normalcase hashState 18.314 ms/op 18.754 ms/op 0.98
altair processBlock - 250000 vs - 7PWei worstcase 39.058 ms/op 44.025 ms/op 0.89
altair processBlock - 250000 vs - 7PWei worstcase hashState 66.039 ms/op 65.860 ms/op 1.00
phase0 processBlock - 250000 vs - 7PWei normalcase 2.4297 ms/op 2.8124 ms/op 0.86
phase0 processBlock - 250000 vs - 7PWei worstcase 31.912 ms/op 34.035 ms/op 0.94
altair processEth1Data - 250000 vs - 7PWei normalcase 478.51 us/op 608.16 us/op 0.79
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 15.010 us/op 12.781 us/op 1.17
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 63.336 us/op 91.718 us/op 0.69
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 25.146 us/op 26.403 us/op 0.95
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 9.4470 us/op 18.782 us/op 0.50
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 198.34 us/op 226.90 us/op 0.87
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.4486 ms/op 1.2451 ms/op 1.16
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.5793 ms/op 2.0209 ms/op 0.78
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.9952 ms/op 1.8609 ms/op 1.07
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.8508 ms/op 3.4022 ms/op 1.13
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.6904 ms/op 2.5259 ms/op 1.07
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 6.2102 ms/op 6.1735 ms/op 1.01
Tree 40 250000 create 426.52 ms/op 556.89 ms/op 0.77
Tree 40 250000 get(125000) 211.55 ns/op 222.44 ns/op 0.95
Tree 40 250000 set(125000) 1.0166 us/op 1.1050 us/op 0.92
Tree 40 250000 toArray() 21.198 ms/op 23.171 ms/op 0.91
Tree 40 250000 iterate all - toArray() + loop 22.261 ms/op 22.145 ms/op 1.01
Tree 40 250000 iterate all - get(i) 74.096 ms/op 81.531 ms/op 0.91
MutableVector 250000 create 11.715 ms/op 16.372 ms/op 0.72
MutableVector 250000 get(125000) 6.8410 ns/op 7.1890 ns/op 0.95
MutableVector 250000 set(125000) 279.88 ns/op 300.48 ns/op 0.93
MutableVector 250000 toArray() 3.8489 ms/op 4.4387 ms/op 0.87
MutableVector 250000 iterate all - toArray() + loop 3.7270 ms/op 4.2099 ms/op 0.89
MutableVector 250000 iterate all - get(i) 1.6165 ms/op 1.6616 ms/op 0.97
Array 250000 create 3.6786 ms/op 3.2625 ms/op 1.13
Array 250000 clone - spread 1.0422 ms/op 1.2222 ms/op 0.85
Array 250000 get(125000) 0.52000 ns/op 0.60100 ns/op 0.87
Array 250000 set(125000) 0.59300 ns/op 0.65600 ns/op 0.90
Array 250000 iterate all - loop 91.738 us/op 87.444 us/op 1.05
effectiveBalanceIncrements clone Uint8Array 300000 24.512 us/op 36.486 us/op 0.67
effectiveBalanceIncrements clone MutableVector 300000 268.00 ns/op 327.00 ns/op 0.82
effectiveBalanceIncrements rw all Uint8Array 300000 188.10 us/op 191.96 us/op 0.98
effectiveBalanceIncrements rw all MutableVector 300000 79.340 ms/op 110.04 ms/op 0.72
phase0 afterProcessEpoch - 250000 vs - 7PWei 119.51 ms/op 124.11 ms/op 0.96
phase0 beforeProcessEpoch - 250000 vs - 7PWei 38.679 ms/op 40.006 ms/op 0.97
altair processEpoch - mainnet_e81889 374.61 ms/op 342.35 ms/op 1.09
mainnet_e81889 - altair beforeProcessEpoch 89.549 ms/op 74.066 ms/op 1.21
mainnet_e81889 - altair processJustificationAndFinalization 31.524 us/op 22.576 us/op 1.40
mainnet_e81889 - altair processInactivityUpdates 8.5557 ms/op 8.3227 ms/op 1.03
mainnet_e81889 - altair processRewardsAndPenalties 86.622 ms/op 61.565 ms/op 1.41
mainnet_e81889 - altair processRegistryUpdates 8.0230 us/op 5.4230 us/op 1.48
mainnet_e81889 - altair processSlashings 1.3670 us/op 1.2340 us/op 1.11
mainnet_e81889 - altair processEth1DataReset 1.1440 us/op 1.4750 us/op 0.78
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.5935 ms/op 1.7000 ms/op 0.94
mainnet_e81889 - altair processSlashingsReset 5.9680 us/op 7.2020 us/op 0.83
mainnet_e81889 - altair processRandaoMixesReset 12.133 us/op 8.0550 us/op 1.51
mainnet_e81889 - altair processHistoricalRootsUpdate 2.3550 us/op 1.9800 us/op 1.19
mainnet_e81889 - altair processParticipationFlagUpdates 7.7870 us/op 5.3610 us/op 1.45
mainnet_e81889 - altair processSyncCommitteeUpdates 2.2880 us/op 1.3730 us/op 1.67
mainnet_e81889 - altair afterProcessEpoch 155.29 ms/op 151.14 ms/op 1.03
capella processEpoch - mainnet_e217614 1.2090 s/op 1.6810 s/op 0.72
mainnet_e217614 - capella beforeProcessEpoch 285.42 ms/op 438.76 ms/op 0.65
mainnet_e217614 - capella processJustificationAndFinalization 22.757 us/op 25.209 us/op 0.90
mainnet_e217614 - capella processInactivityUpdates 19.738 ms/op 26.593 ms/op 0.74
mainnet_e217614 - capella processRewardsAndPenalties 297.71 ms/op 447.02 ms/op 0.67
mainnet_e217614 - capella processRegistryUpdates 25.149 us/op 36.743 us/op 0.68
mainnet_e217614 - capella processSlashings 766.00 ns/op 1.2560 us/op 0.61
mainnet_e217614 - capella processEth1DataReset 880.00 ns/op 1.0520 us/op 0.84
mainnet_e217614 - capella processEffectiveBalanceUpdates 4.4319 ms/op 4.9811 ms/op 0.89
mainnet_e217614 - capella processSlashingsReset 2.2980 us/op 6.4850 us/op 0.35
mainnet_e217614 - capella processRandaoMixesReset 4.0490 us/op 8.9380 us/op 0.45
mainnet_e217614 - capella processHistoricalRootsUpdate 910.00 ns/op 1.3910 us/op 0.65
mainnet_e217614 - capella processParticipationFlagUpdates 1.9240 us/op 6.0140 us/op 0.32
mainnet_e217614 - capella afterProcessEpoch 315.16 ms/op 351.78 ms/op 0.90
phase0 processEpoch - mainnet_e58758 362.10 ms/op 546.78 ms/op 0.66
mainnet_e58758 - phase0 beforeProcessEpoch 143.32 ms/op 254.22 ms/op 0.56
mainnet_e58758 - phase0 processJustificationAndFinalization 17.202 us/op 32.321 us/op 0.53
mainnet_e58758 - phase0 processRewardsAndPenalties 68.692 ms/op 74.082 ms/op 0.93
mainnet_e58758 - phase0 processRegistryUpdates 14.632 us/op 24.613 us/op 0.59
mainnet_e58758 - phase0 processSlashings 769.00 ns/op 2.0070 us/op 0.38
mainnet_e58758 - phase0 processEth1DataReset 808.00 ns/op 1.4750 us/op 0.55
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.1809 ms/op 1.6507 ms/op 0.72
mainnet_e58758 - phase0 processSlashingsReset 2.7860 us/op 6.0060 us/op 0.46
mainnet_e58758 - phase0 processRandaoMixesReset 4.4430 us/op 11.202 us/op 0.40
mainnet_e58758 - phase0 processHistoricalRootsUpdate 870.00 ns/op 615.00 ns/op 1.41
mainnet_e58758 - phase0 processParticipationRecordUpdates 5.0240 us/op 5.1590 us/op 0.97
mainnet_e58758 - phase0 afterProcessEpoch 117.42 ms/op 109.38 ms/op 1.07
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.3414 ms/op 1.3955 ms/op 0.96
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.5267 ms/op 1.7258 ms/op 0.88
altair processInactivityUpdates - 250000 normalcase 27.119 ms/op 28.798 ms/op 0.94
altair processInactivityUpdates - 250000 worstcase 26.358 ms/op 23.510 ms/op 1.12
phase0 processRegistryUpdates - 250000 normalcase 17.935 us/op 16.228 us/op 1.11
phase0 processRegistryUpdates - 250000 badcase_full_deposits 657.97 us/op 501.03 us/op 1.31
phase0 processRegistryUpdates - 250000 worstcase 0.5 173.26 ms/op 155.44 ms/op 1.11
altair processRewardsAndPenalties - 250000 normalcase 88.380 ms/op 74.980 ms/op 1.18
altair processRewardsAndPenalties - 250000 worstcase 80.521 ms/op 66.508 ms/op 1.21
phase0 getAttestationDeltas - 250000 normalcase 9.9309 ms/op 11.147 ms/op 0.89
phase0 getAttestationDeltas - 250000 worstcase 12.314 ms/op 11.493 ms/op 1.07
phase0 processSlashings - 250000 worstcase 2.6806 ms/op 2.8891 ms/op 0.93
altair processSyncCommitteeUpdates - 250000 176.92 ms/op 174.87 ms/op 1.01
BeaconState.hashTreeRoot - No change 360.00 ns/op 313.00 ns/op 1.15
BeaconState.hashTreeRoot - 1 full validator 57.199 us/op 57.806 us/op 0.99
BeaconState.hashTreeRoot - 32 full validator 568.14 us/op 582.57 us/op 0.98
BeaconState.hashTreeRoot - 512 full validator 6.5854 ms/op 7.1272 ms/op 0.92
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 78.800 us/op 72.945 us/op 1.08
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.2092 ms/op 985.15 us/op 1.23
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 13.962 ms/op 14.249 ms/op 0.98
BeaconState.hashTreeRoot - 1 balances 57.094 us/op 55.023 us/op 1.04
BeaconState.hashTreeRoot - 32 balances 482.74 us/op 509.96 us/op 0.95
BeaconState.hashTreeRoot - 512 balances 5.1668 ms/op 5.0173 ms/op 1.03
BeaconState.hashTreeRoot - 250000 balances 91.468 ms/op 75.832 ms/op 1.21
aggregationBits - 2048 els - zipIndexesInBitList 25.266 us/op 21.116 us/op 1.20
regular array get 100000 times 53.806 us/op 46.202 us/op 1.16
wrappedArray get 100000 times 38.849 us/op 34.045 us/op 1.14
arrayWithProxy get 100000 times 19.563 ms/op 15.692 ms/op 1.25
ssz.Root.equals 306.00 ns/op 293.00 ns/op 1.04
byteArrayEquals 307.00 ns/op 285.00 ns/op 1.08
shuffle list - 16384 els 8.6408 ms/op 7.2858 ms/op 1.19
shuffle list - 250000 els 118.01 ms/op 106.44 ms/op 1.11
processSlot - 1 slots 11.101 us/op 9.5250 us/op 1.17
processSlot - 32 slots 1.5732 ms/op 1.4716 ms/op 1.07
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 65.686 ms/op 54.131 ms/op 1.21
getCommitteeAssignments - req 1 vs - 250000 vc 2.8372 ms/op 2.8953 ms/op 0.98
getCommitteeAssignments - req 100 vs - 250000 vc 4.2561 ms/op 4.2364 ms/op 1.00
getCommitteeAssignments - req 1000 vs - 250000 vc 4.5998 ms/op 4.4017 ms/op 1.05
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.9900 ns/op 5.5400 ns/op 1.08
state getBlockRootAtSlot - 250000 vs - 7PWei 1.1273 us/op 1.0900 us/op 1.03
computeProposers - vc 250000 11.949 ms/op 10.275 ms/op 1.16
computeEpochShuffling - vc 250000 123.47 ms/op 109.77 ms/op 1.12
getNextSyncCommittee - vc 250000 180.02 ms/op 166.04 ms/op 1.08
computeSigningRoot for AttestationData 15.325 us/op 15.309 us/op 1.00
hash AttestationData serialized data then Buffer.toString(base64) 2.4725 us/op 2.4908 us/op 0.99
toHexString serialized data 1.2721 us/op 1.3798 us/op 0.92
Buffer.toString(base64) 258.30 ns/op 257.90 ns/op 1.00

by benchmarkbot/action

@wemeetagain wemeetagain merged commit 4468054 into unstable Aug 1, 2023
12 checks passed
@wemeetagain wemeetagain deleted the nflaig/fix-decoding-enrs branch August 1, 2023 16:57
@nflaig nflaig mentioned this pull request Aug 2, 2023
Merged
@nflaig
Copy link
Member Author

nflaig commented Aug 2, 2023 •
edited
Loading

Edit: Created an issue to discuss a strategy for managing bootnode ENRs (#5838)

@nflaig nflaig mentioned this pull request Aug 2, 2023
Closed
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error decoding ENRs from mainnet/bootstrap_nodes.txt
2 participants
@nflaig @wemeetagain