Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: downgrade docker nodejs to 18 #5812

Merged
merged 1 commit into from
Jul 27, 2023
Merged

chore: downgrade docker nodejs to 18 #5812

merged 1 commit into from
Jul 27, 2023

Conversation

wemeetagain
Copy link
Member

Motivation

We're still facing problems related to node-fetch/cross-fetch/native fetch in node 20.

Description

Downgrade docker nodejs version backto 18

@wemeetagain wemeetagain requested a review from a team as a code owner July 27, 2023 16:35
@wemeetagain wemeetagain enabled auto-merge (squash) July 27, 2023 16:43
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 66f58d4 Previous: 201dfc8 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 741.13 us/op 736.46 us/op 1.01
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 91.835 us/op 76.952 us/op 1.19
BLS verify - blst-native 1.2750 ms/op 1.2060 ms/op 1.06
BLS verifyMultipleSignatures 3 - blst-native 2.5955 ms/op 2.4125 ms/op 1.08
BLS verifyMultipleSignatures 8 - blst-native 6.0494 ms/op 5.2197 ms/op 1.16
BLS verifyMultipleSignatures 32 - blst-native 20.080 ms/op 18.944 ms/op 1.06
BLS aggregatePubkeys 32 - blst-native 26.847 us/op 24.972 us/op 1.08
BLS aggregatePubkeys 128 - blst-native 103.54 us/op 97.634 us/op 1.06
getAttestationsForBlock 61.117 ms/op 50.705 ms/op 1.21
isKnown best case - 1 super set check 494.00 ns/op 281.00 ns/op 1.76
isKnown normal case - 2 super set checks 432.00 ns/op 279.00 ns/op 1.55
isKnown worse case - 16 super set checks 465.00 ns/op 273.00 ns/op 1.70
CheckpointStateCache - add get delete 5.5700 us/op 4.8780 us/op 1.14
validate api signedAggregateAndProof - struct 2.8991 ms/op 2.7777 ms/op 1.04
validate gossip signedAggregateAndProof - struct 2.9003 ms/op 2.7793 ms/op 1.04
validate api attestation - struct 1.3859 ms/op 1.2721 ms/op 1.09
validate gossip attestation - struct 1.4394 ms/op 1.3023 ms/op 1.11
pickEth1Vote - no votes 1.4794 ms/op 1.1581 ms/op 1.28
pickEth1Vote - max votes 12.720 ms/op 9.2487 ms/op 1.38
pickEth1Vote - Eth1Data hashTreeRoot value x2048 10.249 ms/op 8.4711 ms/op 1.21
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 16.791 ms/op 13.962 ms/op 1.20
pickEth1Vote - Eth1Data fastSerialize value x2048 709.64 us/op 681.61 us/op 1.04
pickEth1Vote - Eth1Data fastSerialize tree x2048 9.0802 ms/op 6.8071 ms/op 1.33
bytes32 toHexString 730.00 ns/op 474.00 ns/op 1.54
bytes32 Buffer.toString(hex) 328.00 ns/op 296.00 ns/op 1.11
bytes32 Buffer.toString(hex) from Uint8Array 535.00 ns/op 420.00 ns/op 1.27
bytes32 Buffer.toString(hex) + 0x 328.00 ns/op 304.00 ns/op 1.08
Object access 1 prop 0.20700 ns/op 0.15700 ns/op 1.32
Map access 1 prop 0.15300 ns/op 0.15600 ns/op 0.98
Object get x1000 7.1220 ns/op 7.3120 ns/op 0.97
Map get x1000 0.62800 ns/op 0.59200 ns/op 1.06
Object set x1000 60.160 ns/op 46.762 ns/op 1.29
Map set x1000 47.137 ns/op 36.795 ns/op 1.28
Return object 10000 times 0.25620 ns/op 0.22370 ns/op 1.15
Throw Error 10000 times 4.1003 us/op 3.6596 us/op 1.12
fastMsgIdFn sha256 / 200 bytes 3.4870 us/op 3.1150 us/op 1.12
fastMsgIdFn h32 xxhash / 200 bytes 345.00 ns/op 267.00 ns/op 1.29
fastMsgIdFn h64 xxhash / 200 bytes 388.00 ns/op 334.00 ns/op 1.16
fastMsgIdFn sha256 / 1000 bytes 11.892 us/op 10.813 us/op 1.10
fastMsgIdFn h32 xxhash / 1000 bytes 486.00 ns/op 393.00 ns/op 1.24
fastMsgIdFn h64 xxhash / 1000 bytes 467.00 ns/op 408.00 ns/op 1.14
fastMsgIdFn sha256 / 10000 bytes 105.84 us/op 99.007 us/op 1.07
fastMsgIdFn h32 xxhash / 10000 bytes 2.0170 us/op 1.7950 us/op 1.12
fastMsgIdFn h64 xxhash / 10000 bytes 1.3920 us/op 1.2430 us/op 1.12
enrSubnets - fastDeserialize 64 bits 1.5870 us/op 1.1700 us/op 1.36
enrSubnets - ssz BitVector 64 bits 571.00 ns/op 407.00 ns/op 1.40
enrSubnets - fastDeserialize 4 bits 220.00 ns/op 166.00 ns/op 1.33
enrSubnets - ssz BitVector 4 bits 550.00 ns/op 407.00 ns/op 1.35
prioritizePeers score -10:0 att 32-0.1 sync 2-0 111.00 us/op 98.573 us/op 1.13
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 151.83 us/op 124.61 us/op 1.22
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 205.40 us/op 154.11 us/op 1.33
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 344.17 us/op 274.80 us/op 1.25
prioritizePeers score 0:0 att 64-1 sync 4-1 361.35 us/op 328.72 us/op 1.10
array of 16000 items push then shift 1.6040 us/op 1.5440 us/op 1.04
LinkedList of 16000 items push then shift 9.5580 ns/op 8.7310 ns/op 1.09
array of 16000 items push then pop 62.838 ns/op 57.392 ns/op 1.09
LinkedList of 16000 items push then pop 9.2040 ns/op 8.5090 ns/op 1.08
array of 24000 items push then shift 2.4543 us/op 2.3634 us/op 1.04
LinkedList of 24000 items push then shift 9.2840 ns/op 8.8740 ns/op 1.05
array of 24000 items push then pop 119.05 ns/op 106.45 ns/op 1.12
LinkedList of 24000 items push then pop 9.4390 ns/op 8.6820 ns/op 1.09
intersect bitArray bitLen 8 6.9330 ns/op 6.8440 ns/op 1.01
intersect array and set length 8 66.674 ns/op 61.103 ns/op 1.09
intersect bitArray bitLen 128 32.488 ns/op 32.333 ns/op 1.00
intersect array and set length 128 934.36 ns/op 804.44 ns/op 1.16
bitArray.getTrueBitIndexes() bitLen 128 1.8850 us/op 1.6500 us/op 1.14
bitArray.getTrueBitIndexes() bitLen 248 3.2480 us/op 2.6290 us/op 1.24
bitArray.getTrueBitIndexes() bitLen 512 6.2010 us/op 5.0300 us/op 1.23
Buffer.concat 32 items 1.0710 us/op 977.00 ns/op 1.10
Uint8Array.set 32 items 2.8380 us/op 1.7740 us/op 1.60
transfer serialized Status (84 B) 2.1100 us/op 1.8300 us/op 1.15
copy serialized Status (84 B) 1.7250 us/op 1.5190 us/op 1.14
transfer serialized SignedVoluntaryExit (112 B) 2.2720 us/op 1.9490 us/op 1.17
copy serialized SignedVoluntaryExit (112 B) 1.9630 us/op 1.5780 us/op 1.24
transfer serialized ProposerSlashing (416 B) 3.4070 us/op 2.2210 us/op 1.53
copy serialized ProposerSlashing (416 B) 3.4700 us/op 1.7850 us/op 1.94
transfer serialized Attestation (485 B) 3.7460 us/op 1.9960 us/op 1.88
copy serialized Attestation (485 B) 3.5330 us/op 1.7470 us/op 2.02
transfer serialized AttesterSlashing (33232 B) 3.1630 us/op 2.0960 us/op 1.51
copy serialized AttesterSlashing (33232 B) 9.6320 us/op 4.8500 us/op 1.99
transfer serialized Small SignedBeaconBlock (128000 B) 3.0860 us/op 2.3500 us/op 1.31
copy serialized Small SignedBeaconBlock (128000 B) 28.125 us/op 13.614 us/op 2.07
transfer serialized Avg SignedBeaconBlock (200000 B) 3.5260 us/op 2.7240 us/op 1.29
copy serialized Avg SignedBeaconBlock (200000 B) 37.885 us/op 22.651 us/op 1.67
transfer serialized BlobsSidecar (524380 B) 3.5310 us/op 2.7100 us/op 1.30
copy serialized BlobsSidecar (524380 B) 233.33 us/op 123.40 us/op 1.89
transfer serialized Big SignedBeaconBlock (1000000 B) 4.0200 us/op 3.4040 us/op 1.18
copy serialized Big SignedBeaconBlock (1000000 B) 645.58 us/op 163.88 us/op 3.94
pass gossip attestations to forkchoice per slot 2.4074 ms/op 2.1666 ms/op 1.11
forkChoice updateHead vc 100000 bc 64 eq 0 2.3385 ms/op 2.1244 ms/op 1.10
forkChoice updateHead vc 600000 bc 64 eq 0 11.525 ms/op 14.343 ms/op 0.80
forkChoice updateHead vc 1000000 bc 64 eq 0 18.866 ms/op 23.352 ms/op 0.81
forkChoice updateHead vc 600000 bc 320 eq 0 16.635 ms/op 17.349 ms/op 0.96
forkChoice updateHead vc 600000 bc 1200 eq 0 86.637 ms/op 88.877 ms/op 0.97
forkChoice updateHead vc 600000 bc 64 eq 1000 19.188 ms/op 22.864 ms/op 0.84
forkChoice updateHead vc 600000 bc 64 eq 10000 21.292 ms/op 24.458 ms/op 0.87
forkChoice updateHead vc 600000 bc 64 eq 300000 29.157 ms/op 30.592 ms/op 0.95
computeDeltas 3.1623 ms/op 3.2318 ms/op 0.98
computeProposerBoostScoreFromBalances 398.70 us/op 392.91 us/op 1.01
altair processAttestation - 250000 vs - 7PWei normalcase 2.8609 ms/op 2.6320 ms/op 1.09
altair processAttestation - 250000 vs - 7PWei worstcase 4.0073 ms/op 4.2532 ms/op 0.94
altair processAttestation - setStatus - 1/6 committees join 194.86 us/op 196.44 us/op 0.99
altair processAttestation - setStatus - 1/3 committees join 376.14 us/op 355.23 us/op 1.06
altair processAttestation - setStatus - 1/2 committees join 489.60 us/op 475.73 us/op 1.03
altair processAttestation - setStatus - 2/3 committees join 665.07 us/op 605.79 us/op 1.10
altair processAttestation - setStatus - 4/5 committees join 862.56 us/op 853.38 us/op 1.01
altair processAttestation - setStatus - 100% committees join 1.1172 ms/op 997.52 us/op 1.12
altair processBlock - 250000 vs - 7PWei normalcase 10.058 ms/op 11.037 ms/op 0.91
altair processBlock - 250000 vs - 7PWei normalcase hashState 18.970 ms/op 18.173 ms/op 1.04
altair processBlock - 250000 vs - 7PWei worstcase 41.864 ms/op 39.992 ms/op 1.05
altair processBlock - 250000 vs - 7PWei worstcase hashState 66.466 ms/op 63.599 ms/op 1.05
phase0 processBlock - 250000 vs - 7PWei normalcase 3.6432 ms/op 2.6827 ms/op 1.36
phase0 processBlock - 250000 vs - 7PWei worstcase 43.140 ms/op 31.686 ms/op 1.36
altair processEth1Data - 250000 vs - 7PWei normalcase 650.36 us/op 536.23 us/op 1.21
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 19.150 us/op 10.017 us/op 1.91
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 107.12 us/op 84.141 us/op 1.27
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 35.893 us/op 26.863 us/op 1.34
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 23.497 us/op 15.207 us/op 1.55
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 221.73 us/op 166.59 us/op 1.33
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 2.3806 ms/op 1.5911 ms/op 1.50
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 2.4810 ms/op 1.8075 ms/op 1.37
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 2.8770 ms/op 2.1619 ms/op 1.33
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 7.6140 ms/op 4.5320 ms/op 1.68
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 3.8193 ms/op 2.7610 ms/op 1.38
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 10.515 ms/op 6.7336 ms/op 1.56
Tree 40 250000 create 693.75 ms/op 412.15 ms/op 1.68
Tree 40 250000 get(125000) 217.20 ns/op 214.60 ns/op 1.01
Tree 40 250000 set(125000) 1.7689 us/op 1.0545 us/op 1.68
Tree 40 250000 toArray() 32.220 ms/op 21.457 ms/op 1.50
Tree 40 250000 iterate all - toArray() + loop 39.334 ms/op 23.558 ms/op 1.67
Tree 40 250000 iterate all - get(i) 86.837 ms/op 74.195 ms/op 1.17
MutableVector 250000 create 14.926 ms/op 10.088 ms/op 1.48
MutableVector 250000 get(125000) 7.8100 ns/op 6.5350 ns/op 1.20
MutableVector 250000 set(125000) 470.05 ns/op 288.00 ns/op 1.63
MutableVector 250000 toArray() 4.7788 ms/op 3.9755 ms/op 1.20
MutableVector 250000 iterate all - toArray() + loop 5.2779 ms/op 4.1078 ms/op 1.28
MutableVector 250000 iterate all - get(i) 1.7664 ms/op 1.6852 ms/op 1.05
Array 250000 create 4.4599 ms/op 3.2554 ms/op 1.37
Array 250000 clone - spread 1.3090 ms/op 1.0297 ms/op 1.27
Array 250000 get(125000) 0.65900 ns/op 0.50300 ns/op 1.31
Array 250000 set(125000) 0.71300 ns/op 0.58500 ns/op 1.22
Array 250000 iterate all - loop 91.603 us/op 113.17 us/op 0.81
effectiveBalanceIncrements clone Uint8Array 300000 115.24 us/op 23.943 us/op 4.81
effectiveBalanceIncrements clone MutableVector 300000 578.00 ns/op 268.00 ns/op 2.16
effectiveBalanceIncrements rw all Uint8Array 300000 198.43 us/op 182.05 us/op 1.09
effectiveBalanceIncrements rw all MutableVector 300000 156.41 ms/op 76.216 ms/op 2.05
phase0 afterProcessEpoch - 250000 vs - 7PWei 122.03 ms/op 116.38 ms/op 1.05
phase0 beforeProcessEpoch - 250000 vs - 7PWei 58.101 ms/op 30.847 ms/op 1.88
altair processEpoch - mainnet_e81889 358.52 ms/op 313.97 ms/op 1.14
mainnet_e81889 - altair beforeProcessEpoch 69.713 ms/op 58.640 ms/op 1.19
mainnet_e81889 - altair processJustificationAndFinalization 19.229 us/op 15.578 us/op 1.23
mainnet_e81889 - altair processInactivityUpdates 6.0690 ms/op 5.0689 ms/op 1.20
mainnet_e81889 - altair processRewardsAndPenalties 66.795 ms/op 66.662 ms/op 1.00
mainnet_e81889 - altair processRegistryUpdates 5.5970 us/op 2.5930 us/op 2.16
mainnet_e81889 - altair processSlashings 447.00 ns/op 443.00 ns/op 1.01
mainnet_e81889 - altair processEth1DataReset 1.2850 us/op 539.00 ns/op 2.38
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.3322 ms/op 1.2514 ms/op 1.06
mainnet_e81889 - altair processSlashingsReset 4.0050 us/op 2.6530 us/op 1.51
mainnet_e81889 - altair processRandaoMixesReset 5.2430 us/op 4.4260 us/op 1.18
mainnet_e81889 - altair processHistoricalRootsUpdate 1.9530 us/op 710.00 ns/op 2.75
mainnet_e81889 - altair processParticipationFlagUpdates 2.6700 us/op 2.9580 us/op 0.90
mainnet_e81889 - altair processSyncCommitteeUpdates 784.00 ns/op 569.00 ns/op 1.38
mainnet_e81889 - altair afterProcessEpoch 134.37 ms/op 127.27 ms/op 1.06
phase0 processEpoch - mainnet_e58758 397.17 ms/op 359.90 ms/op 1.10
mainnet_e58758 - phase0 beforeProcessEpoch 154.86 ms/op 129.91 ms/op 1.19
mainnet_e58758 - phase0 processJustificationAndFinalization 20.740 us/op 13.882 us/op 1.49
mainnet_e58758 - phase0 processRewardsAndPenalties 74.180 ms/op 66.066 ms/op 1.12
mainnet_e58758 - phase0 processRegistryUpdates 20.138 us/op 11.076 us/op 1.82
mainnet_e58758 - phase0 processSlashings 962.00 ns/op 466.00 ns/op 2.06
mainnet_e58758 - phase0 processEth1DataReset 794.00 ns/op 458.00 ns/op 1.73
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.1723 ms/op 1.3583 ms/op 0.86
mainnet_e58758 - phase0 processSlashingsReset 3.1780 us/op 2.0530 us/op 1.55
mainnet_e58758 - phase0 processRandaoMixesReset 6.3160 us/op 4.6770 us/op 1.35
mainnet_e58758 - phase0 processHistoricalRootsUpdate 678.00 ns/op 539.00 ns/op 1.26
mainnet_e58758 - phase0 processParticipationRecordUpdates 6.9280 us/op 2.9920 us/op 2.32
mainnet_e58758 - phase0 afterProcessEpoch 103.98 ms/op 97.915 ms/op 1.06
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.6637 ms/op 1.2475 ms/op 1.33
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.8338 ms/op 1.4011 ms/op 1.31
altair processInactivityUpdates - 250000 normalcase 34.021 ms/op 24.568 ms/op 1.38
altair processInactivityUpdates - 250000 worstcase 33.539 ms/op 23.642 ms/op 1.42
phase0 processRegistryUpdates - 250000 normalcase 19.628 us/op 10.271 us/op 1.91
phase0 processRegistryUpdates - 250000 badcase_full_deposits 472.11 us/op 380.47 us/op 1.24
phase0 processRegistryUpdates - 250000 worstcase 0.5 174.31 ms/op 133.40 ms/op 1.31
altair processRewardsAndPenalties - 250000 normalcase 83.011 ms/op 69.278 ms/op 1.20
altair processRewardsAndPenalties - 250000 worstcase 99.337 ms/op 71.947 ms/op 1.38
phase0 getAttestationDeltas - 250000 normalcase 13.724 ms/op 8.2133 ms/op 1.67
phase0 getAttestationDeltas - 250000 worstcase 11.725 ms/op 8.9916 ms/op 1.30
phase0 processSlashings - 250000 worstcase 3.6298 ms/op 2.4953 ms/op 1.45
altair processSyncCommitteeUpdates - 250000 200.90 ms/op 173.22 ms/op 1.16
BeaconState.hashTreeRoot - No change 332.00 ns/op 327.00 ns/op 1.02
BeaconState.hashTreeRoot - 1 full validator 58.386 us/op 54.734 us/op 1.07
BeaconState.hashTreeRoot - 32 full validator 559.43 us/op 617.30 us/op 0.91
BeaconState.hashTreeRoot - 512 full validator 7.9517 ms/op 5.6991 ms/op 1.40
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 71.266 us/op 68.706 us/op 1.04
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.0425 ms/op 1.0228 ms/op 1.02
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 13.386 ms/op 13.660 ms/op 0.98
BeaconState.hashTreeRoot - 1 balances 53.735 us/op 56.762 us/op 0.95
BeaconState.hashTreeRoot - 32 balances 495.25 us/op 473.04 us/op 1.05
BeaconState.hashTreeRoot - 512 balances 5.4247 ms/op 5.1815 ms/op 1.05
BeaconState.hashTreeRoot - 250000 balances 80.054 ms/op 80.260 ms/op 1.00
aggregationBits - 2048 els - zipIndexesInBitList 30.167 us/op 20.062 us/op 1.50
regular array get 100000 times 50.061 us/op 45.652 us/op 1.10
wrappedArray get 100000 times 45.236 us/op 34.819 us/op 1.30
arrayWithProxy get 100000 times 16.344 ms/op 15.525 ms/op 1.05
ssz.Root.equals 256.00 ns/op 255.00 ns/op 1.00
byteArrayEquals 260.00 ns/op 262.00 ns/op 0.99
shuffle list - 16384 els 7.2626 ms/op 7.3421 ms/op 0.99
shuffle list - 250000 els 108.55 ms/op 107.97 ms/op 1.01
processSlot - 1 slots 10.371 us/op 9.5040 us/op 1.09
processSlot - 32 slots 1.5072 ms/op 1.4373 ms/op 1.05
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 61.450 ms/op 59.367 ms/op 1.04
getCommitteeAssignments - req 1 vs - 250000 vc 2.6116 ms/op 2.5965 ms/op 1.01
getCommitteeAssignments - req 100 vs - 250000 vc 3.8277 ms/op 3.8568 ms/op 0.99
getCommitteeAssignments - req 1000 vs - 250000 vc 4.1928 ms/op 4.2408 ms/op 0.99
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.3000 ns/op 5.2800 ns/op 1.00
state getBlockRootAtSlot - 250000 vs - 7PWei 1.0988 us/op 636.85 ns/op 1.73
computeProposers - vc 250000 10.056 ms/op 9.3891 ms/op 1.07
computeEpochShuffling - vc 250000 113.75 ms/op 107.68 ms/op 1.06
getNextSyncCommittee - vc 250000 171.74 ms/op 156.90 ms/op 1.09
computeSigningRoot for AttestationData 14.948 us/op 13.680 us/op 1.09
hash AttestationData serialized data then Buffer.toString(base64) 2.4497 us/op 2.4098 us/op 1.02
toHexString serialized data 1.2564 us/op 1.0786 us/op 1.16
Buffer.toString(base64) 256.02 ns/op 215.32 ns/op 1.19

by benchmarkbot/action

@wemeetagain wemeetagain merged commit a752d15 into unstable Jul 27, 2023
10 of 11 checks passed
@wemeetagain wemeetagain deleted the cayman/downgrade-docker-node branch July 27, 2023 16:51
wemeetagain added a commit that referenced this pull request Jul 31, 2023
@wemeetagain
chore: update docker nodejs to 20
7b43f4a 
Revert "chore: downgrade docker nodejs to 18 (#5812)"

This reverts commit a752d15.
@wemeetagain wemeetagain mentioned this pull request Jul 31, 2023
Merged
wemeetagain added a commit that referenced this pull request Aug 1, 2023
@wemeetagain
chore: update docker nodejs to 20 (#5825)
00b94f3 
Revert "chore: downgrade docker nodejs to 18 (#5812)"

This reverts commit a752d15.
@wemeetagain
Copy link
Member Author

🎉 This PR is included in v1.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nflaig nflaig nflaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wemeetagain @nflaig