Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor dashboards fixes, grafana update related changes #5210

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Minor dashboards fixes, grafana update related changes #5210

merged 1 commit into from
Feb 28, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Feb 27, 2023

Motivation

As suggested in #5200 (review), the initial PR #5200 should be split into two separate PRs

Description

  • Almost all the changes in this PR are related to a newer grafana version
  • Also fixes broken panel in vm+host dashboard which could not be edited, I think this was related to incorrect x/y coordinates
  • Typo fix and few title updates, nothing special..

@nflaig nflaig mentioned this pull request Feb 27, 2023
Merged
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: ee1de66 Previous: 6429685 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 515.33 us/op 501.82 us/op 1.03
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 47.619 us/op 47.651 us/op 1.00
BLS verify - blst-native 1.2183 ms/op 1.2347 ms/op 0.99
BLS verifyMultipleSignatures 3 - blst-native 2.5334 ms/op 2.4597 ms/op 1.03
BLS verifyMultipleSignatures 8 - blst-native 5.3588 ms/op 5.2457 ms/op 1.02
BLS verifyMultipleSignatures 32 - blst-native 19.396 ms/op 19.187 ms/op 1.01
BLS aggregatePubkeys 32 - blst-native 25.942 us/op 25.852 us/op 1.00
BLS aggregatePubkeys 128 - blst-native 102.47 us/op 99.981 us/op 1.02
getAttestationsForBlock 59.331 ms/op 52.230 ms/op 1.14
isKnown best case - 1 super set check 265.00 ns/op 266.00 ns/op 1.00
isKnown normal case - 2 super set checks 258.00 ns/op 261.00 ns/op 0.99
isKnown worse case - 16 super set checks 257.00 ns/op 255.00 ns/op 1.01
CheckpointStateCache - add get delete 5.3910 us/op 5.2070 us/op 1.04
validate gossip signedAggregateAndProof - struct 2.8120 ms/op 2.7806 ms/op 1.01
validate gossip attestation - struct 1.3280 ms/op 1.3248 ms/op 1.00
pickEth1Vote - no votes 1.3036 ms/op 1.2324 ms/op 1.06
pickEth1Vote - max votes 11.399 ms/op 10.539 ms/op 1.08
pickEth1Vote - Eth1Data hashTreeRoot value x2048 8.5434 ms/op 8.6177 ms/op 0.99
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 14.324 ms/op 14.883 ms/op 0.96
pickEth1Vote - Eth1Data fastSerialize value x2048 644.03 us/op 637.53 us/op 1.01
pickEth1Vote - Eth1Data fastSerialize tree x2048 6.3788 ms/op 8.0863 ms/op 0.79
bytes32 toHexString 501.00 ns/op 518.00 ns/op 0.97
bytes32 Buffer.toString(hex) 341.00 ns/op 346.00 ns/op 0.99
bytes32 Buffer.toString(hex) from Uint8Array 541.00 ns/op 556.00 ns/op 0.97
bytes32 Buffer.toString(hex) + 0x 350.00 ns/op 337.00 ns/op 1.04
Object access 1 prop 0.16900 ns/op 0.17200 ns/op 0.98
Map access 1 prop 0.16600 ns/op 0.15800 ns/op 1.05
Object get x1000 6.4910 ns/op 6.5440 ns/op 0.99
Map get x1000 0.55200 ns/op 0.63800 ns/op 0.87
Object set x1000 55.043 ns/op 53.499 ns/op 1.03
Map set x1000 44.073 ns/op 43.388 ns/op 1.02
Return object 10000 times 0.23930 ns/op 0.23350 ns/op 1.02
Throw Error 10000 times 4.2161 us/op 4.0574 us/op 1.04
fastMsgIdFn sha256 / 200 bytes 3.5550 us/op 3.4370 us/op 1.03
fastMsgIdFn h32 xxhash / 200 bytes 306.00 ns/op 271.00 ns/op 1.13
fastMsgIdFn h64 xxhash / 200 bytes 415.00 ns/op 382.00 ns/op 1.09
fastMsgIdFn sha256 / 1000 bytes 11.767 us/op 11.500 us/op 1.02
fastMsgIdFn h32 xxhash / 1000 bytes 406.00 ns/op 401.00 ns/op 1.01
fastMsgIdFn h64 xxhash / 1000 bytes 461.00 ns/op 453.00 ns/op 1.02
fastMsgIdFn sha256 / 10000 bytes 104.16 us/op 103.31 us/op 1.01
fastMsgIdFn h32 xxhash / 10000 bytes 1.9470 us/op 1.9190 us/op 1.01
fastMsgIdFn h64 xxhash / 10000 bytes 1.3540 us/op 1.3700 us/op 0.99
enrSubnets - fastDeserialize 64 bits 1.3740 us/op 1.2790 us/op 1.07
enrSubnets - ssz BitVector 64 bits 484.00 ns/op 487.00 ns/op 0.99
enrSubnets - fastDeserialize 4 bits 177.00 ns/op 165.00 ns/op 1.07
enrSubnets - ssz BitVector 4 bits 564.00 ns/op 484.00 ns/op 1.17
prioritizePeers score -10:0 att 32-0.1 sync 2-0 108.45 us/op 94.454 us/op 1.15
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 147.49 us/op 129.13 us/op 1.14
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 173.96 us/op 159.38 us/op 1.09
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 314.49 us/op 298.36 us/op 1.05
prioritizePeers score 0:0 att 64-1 sync 4-1 398.98 us/op 355.85 us/op 1.12
array of 16000 items push then shift 1.6710 us/op 1.6224 us/op 1.03
LinkedList of 16000 items push then shift 9.2410 ns/op 8.6630 ns/op 1.07
array of 16000 items push then pop 109.00 ns/op 91.372 ns/op 1.19
LinkedList of 16000 items push then pop 8.7310 ns/op 8.5070 ns/op 1.03
array of 24000 items push then shift 2.4001 us/op 2.3615 us/op 1.02
LinkedList of 24000 items push then shift 8.9560 ns/op 8.7140 ns/op 1.03
array of 24000 items push then pop 79.441 ns/op 71.467 ns/op 1.11
LinkedList of 24000 items push then pop 8.6200 ns/op 8.4250 ns/op 1.02
intersect bitArray bitLen 8 13.124 ns/op 13.129 ns/op 1.00
intersect array and set length 8 83.448 ns/op 74.890 ns/op 1.11
intersect bitArray bitLen 128 43.500 ns/op 43.862 ns/op 0.99
intersect array and set length 128 1.0833 us/op 1.0088 us/op 1.07
Buffer.concat 32 items 2.7270 us/op 2.5570 us/op 1.07
Uint8Array.set 32 items 2.1820 us/op 2.9280 us/op 0.75
pass gossip attestations to forkchoice per slot 3.6534 ms/op 2.2924 ms/op 1.59
computeDeltas 2.9545 ms/op 3.1269 ms/op 0.94
computeProposerBoostScoreFromBalances 1.7895 ms/op 1.7704 ms/op 1.01
altair processAttestation - 250000 vs - 7PWei normalcase 2.2525 ms/op 2.1404 ms/op 1.05
altair processAttestation - 250000 vs - 7PWei worstcase 3.6249 ms/op 3.6171 ms/op 1.00
altair processAttestation - setStatus - 1/6 committees join 138.30 us/op 141.64 us/op 0.98
altair processAttestation - setStatus - 1/3 committees join 274.42 us/op 270.86 us/op 1.01
altair processAttestation - setStatus - 1/2 committees join 367.84 us/op 383.23 us/op 0.96
altair processAttestation - setStatus - 2/3 committees join 460.18 us/op 471.23 us/op 0.98
altair processAttestation - setStatus - 4/5 committees join 637.38 us/op 656.46 us/op 0.97
altair processAttestation - setStatus - 100% committees join 742.83 us/op 757.31 us/op 0.98
altair processBlock - 250000 vs - 7PWei normalcase 19.066 ms/op 18.627 ms/op 1.02
altair processBlock - 250000 vs - 7PWei normalcase hashState 25.898 ms/op 24.894 ms/op 1.04
altair processBlock - 250000 vs - 7PWei worstcase 47.472 ms/op 49.819 ms/op 0.95
altair processBlock - 250000 vs - 7PWei worstcase hashState 70.723 ms/op 70.850 ms/op 1.00
phase0 processBlock - 250000 vs - 7PWei normalcase 1.8618 ms/op 2.0462 ms/op 0.91
phase0 processBlock - 250000 vs - 7PWei worstcase 27.761 ms/op 28.808 ms/op 0.96
altair processEth1Data - 250000 vs - 7PWei normalcase 457.43 us/op 518.76 us/op 0.88
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15 6.9280 us/op 7.7560 us/op 0.89
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219 19.943 us/op 23.546 us/op 0.85
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42 8.5440 us/op 8.7400 us/op 0.98
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18 6.6690 us/op 7.3930 us/op 0.90
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020 74.976 us/op 87.102 us/op 0.86
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777 626.82 us/op 642.39 us/op 0.98
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384 883.17 us/op 938.05 us/op 0.94
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384 876.91 us/op 900.78 us/op 0.97
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384 2.3143 ms/op 2.2853 ms/op 1.01
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384 1.4338 ms/op 1.5872 ms/op 0.90
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384 3.5767 ms/op 3.8638 ms/op 0.93
Tree 40 250000 create 291.39 ms/op 320.21 ms/op 0.91
Tree 40 250000 get(125000) 178.10 ns/op 190.51 ns/op 0.93
Tree 40 250000 set(125000) 896.36 ns/op 974.91 ns/op 0.92
Tree 40 250000 toArray() 17.312 ms/op 18.697 ms/op 0.93
Tree 40 250000 iterate all - toArray() + loop 17.061 ms/op 17.977 ms/op 0.95
Tree 40 250000 iterate all - get(i) 66.469 ms/op 69.036 ms/op 0.96
MutableVector 250000 create 10.351 ms/op 11.374 ms/op 0.91
MutableVector 250000 get(125000) 6.3450 ns/op 6.4330 ns/op 0.99
MutableVector 250000 set(125000) 249.78 ns/op 258.63 ns/op 0.97
MutableVector 250000 toArray() 2.7220 ms/op 3.1389 ms/op 0.87
MutableVector 250000 iterate all - toArray() + loop 2.8567 ms/op 3.1263 ms/op 0.91
MutableVector 250000 iterate all - get(i) 1.5067 ms/op 1.5051 ms/op 1.00
Array 250000 create 2.5696 ms/op 2.7506 ms/op 0.93
Array 250000 clone - spread 1.1663 ms/op 1.1613 ms/op 1.00
Array 250000 get(125000) 0.55900 ns/op 0.56700 ns/op 0.99
Array 250000 set(125000) 0.65100 ns/op 0.64900 ns/op 1.00
Array 250000 iterate all - loop 96.731 us/op 106.61 us/op 0.91
effectiveBalanceIncrements clone Uint8Array 300000 27.619 us/op 26.972 us/op 1.02
effectiveBalanceIncrements clone MutableVector 300000 365.00 ns/op 364.00 ns/op 1.00
effectiveBalanceIncrements rw all Uint8Array 300000 166.93 us/op 167.11 us/op 1.00
effectiveBalanceIncrements rw all MutableVector 300000 80.370 ms/op 86.848 ms/op 0.93
phase0 afterProcessEpoch - 250000 vs - 7PWei 111.94 ms/op 113.60 ms/op 0.99
phase0 beforeProcessEpoch - 250000 vs - 7PWei 35.399 ms/op 42.130 ms/op 0.84
altair processEpoch - mainnet_e81889 327.43 ms/op 336.99 ms/op 0.97
mainnet_e81889 - altair beforeProcessEpoch 63.058 ms/op 65.252 ms/op 0.97
mainnet_e81889 - altair processJustificationAndFinalization 18.031 us/op 20.081 us/op 0.90
mainnet_e81889 - altair processInactivityUpdates 5.3911 ms/op 5.5917 ms/op 0.96
mainnet_e81889 - altair processRewardsAndPenalties 67.141 ms/op 68.716 ms/op 0.98
mainnet_e81889 - altair processRegistryUpdates 2.5970 us/op 2.7080 us/op 0.96
mainnet_e81889 - altair processSlashings 431.00 ns/op 416.00 ns/op 1.04
mainnet_e81889 - altair processEth1DataReset 510.00 ns/op 472.00 ns/op 1.08
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2248 ms/op 1.2450 ms/op 0.98
mainnet_e81889 - altair processSlashingsReset 4.6900 us/op 6.6780 us/op 0.70
mainnet_e81889 - altair processRandaoMixesReset 4.5670 us/op 4.5860 us/op 1.00
mainnet_e81889 - altair processHistoricalRootsUpdate 622.00 ns/op 691.00 ns/op 0.90
mainnet_e81889 - altair processParticipationFlagUpdates 2.4240 us/op 2.7900 us/op 0.87
mainnet_e81889 - altair processSyncCommitteeUpdates 489.00 ns/op 477.00 ns/op 1.03
mainnet_e81889 - altair afterProcessEpoch 117.14 ms/op 119.57 ms/op 0.98
phase0 processEpoch - mainnet_e58758 314.74 ms/op 359.24 ms/op 0.88
mainnet_e58758 - phase0 beforeProcessEpoch 120.87 ms/op 118.33 ms/op 1.02
mainnet_e58758 - phase0 processJustificationAndFinalization 16.339 us/op 18.744 us/op 0.87
mainnet_e58758 - phase0 processRewardsAndPenalties 53.122 ms/op 53.120 ms/op 1.00
mainnet_e58758 - phase0 processRegistryUpdates 7.7690 us/op 9.0260 us/op 0.86
mainnet_e58758 - phase0 processSlashings 498.00 ns/op 691.00 ns/op 0.72
mainnet_e58758 - phase0 processEth1DataReset 495.00 ns/op 911.00 ns/op 0.54
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 995.50 us/op 1.0694 ms/op 0.93
mainnet_e58758 - phase0 processSlashingsReset 3.6540 us/op 8.7260 us/op 0.42
mainnet_e58758 - phase0 processRandaoMixesReset 4.5940 us/op 6.2800 us/op 0.73
mainnet_e58758 - phase0 processHistoricalRootsUpdate 527.00 ns/op 1.0500 us/op 0.50
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.9760 us/op 6.0350 us/op 0.66
mainnet_e58758 - phase0 afterProcessEpoch 96.377 ms/op 108.81 ms/op 0.89
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2077 ms/op 1.2805 ms/op 0.94
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4045 ms/op 1.5131 ms/op 0.93
altair processInactivityUpdates - 250000 normalcase 19.180 ms/op 31.694 ms/op 0.61
altair processInactivityUpdates - 250000 worstcase 22.165 ms/op 31.119 ms/op 0.71
phase0 processRegistryUpdates - 250000 normalcase 6.5610 us/op 7.6090 us/op 0.86
phase0 processRegistryUpdates - 250000 badcase_full_deposits 251.62 us/op 282.55 us/op 0.89
phase0 processRegistryUpdates - 250000 worstcase 0.5 124.55 ms/op 129.54 ms/op 0.96
altair processRewardsAndPenalties - 250000 normalcase 48.300 ms/op 67.912 ms/op 0.71
altair processRewardsAndPenalties - 250000 worstcase 55.801 ms/op 70.477 ms/op 0.79
phase0 getAttestationDeltas - 250000 normalcase 6.5090 ms/op 6.6152 ms/op 0.98
phase0 getAttestationDeltas - 250000 worstcase 6.6884 ms/op 6.6152 ms/op 1.01
phase0 processSlashings - 250000 worstcase 3.4377 ms/op 3.5179 ms/op 0.98
altair processSyncCommitteeUpdates - 250000 171.48 ms/op 178.25 ms/op 0.96
BeaconState.hashTreeRoot - No change 262.00 ns/op 287.00 ns/op 0.91
BeaconState.hashTreeRoot - 1 full validator 50.620 us/op 54.115 us/op 0.94
BeaconState.hashTreeRoot - 32 full validator 498.86 us/op 522.26 us/op 0.96
BeaconState.hashTreeRoot - 512 full validator 4.9588 ms/op 5.7720 ms/op 0.86
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 62.880 us/op 67.571 us/op 0.93
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 843.70 us/op 908.62 us/op 0.93
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 11.004 ms/op 11.362 ms/op 0.97
BeaconState.hashTreeRoot - 1 balances 47.129 us/op 51.670 us/op 0.91
BeaconState.hashTreeRoot - 32 balances 440.06 us/op 475.52 us/op 0.93
BeaconState.hashTreeRoot - 512 balances 4.2684 ms/op 4.6600 ms/op 0.92
BeaconState.hashTreeRoot - 250000 balances 77.881 ms/op 78.035 ms/op 1.00
aggregationBits - 2048 els - zipIndexesInBitList 16.921 us/op 17.640 us/op 0.96
regular array get 100000 times 32.122 us/op 34.921 us/op 0.92
wrappedArray get 100000 times 32.793 us/op 33.645 us/op 0.97
arrayWithProxy get 100000 times 15.204 ms/op 16.543 ms/op 0.92
ssz.Root.equals 529.00 ns/op 645.00 ns/op 0.82
byteArrayEquals 532.00 ns/op 600.00 ns/op 0.89
shuffle list - 16384 els 6.7344 ms/op 7.0164 ms/op 0.96
shuffle list - 250000 els 100.58 ms/op 103.38 ms/op 0.97
processSlot - 1 slots 9.6470 us/op 9.5260 us/op 1.01
processSlot - 32 slots 1.4135 ms/op 1.4200 ms/op 1.00
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 199.48 us/op 220.55 us/op 0.90
getCommitteeAssignments - req 1 vs - 250000 vc 2.8377 ms/op 2.9679 ms/op 0.96
getCommitteeAssignments - req 100 vs - 250000 vc 4.0822 ms/op 4.1616 ms/op 0.98
getCommitteeAssignments - req 1000 vs - 250000 vc 4.4372 ms/op 4.4698 ms/op 0.99
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.4500 ns/op 5.1400 ns/op 0.87
state getBlockRootAtSlot - 250000 vs - 7PWei 972.01 ns/op 851.32 ns/op 1.14
computeProposers - vc 250000 11.069 ms/op 11.298 ms/op 0.98
computeEpochShuffling - vc 250000 104.57 ms/op 104.04 ms/op 1.01
getNextSyncCommittee - vc 250000 183.89 ms/op 188.42 ms/op 0.98

by benchmarkbot/action

@nflaig nflaig mentioned this pull request Feb 27, 2023
Closed
@nflaig nflaig marked this pull request as ready for review February 27, 2023 19:39
@nflaig nflaig requested a review from a team as a code owner February 27, 2023 19:39
@dapplion dapplion merged commit 724e29d into unstable Feb 28, 2023
@dapplion dapplion deleted the nflaig/general-dashboard-updates branch February 28, 2023 04:12
dapplion pushed a commit that referenced this pull request Feb 28, 2023
@nflaig @dapplion
Minor dashboards fixes, grafana update related changes (#5210)
b735890
@nflaig nflaig mentioned this pull request Mar 1, 2023
Merged
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.6.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nflaig @wemeetagain @dapplion