Cache and retransmit bls changes if submitted early #5031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
dapplion
reviewed
Jan 22, 2023
dapplion
reviewed
Jan 22, 2023
| @@ -33,6 +33,7 @@ export enum Bucket { | |||
| phase0_proposerSlashing = 14, // ValidatorIndex -> ProposerSlashing | |||
| phase0_attesterSlashing = 15, // Root -> AttesterSlashing | |||
| capella_blsToExecutionChange = 16, // ValidatorIndex -> SignedBLSToExecutionChange | |||
| capella_blsToExecutionChangeCache = 17, // ValidatorIndex -> SignedBLSToExecutionChange | |||
There was a problem hiding this comment.
You should be able to recycle the existing in-memory + DB pool. Why is this extra bucket required?
There was a problem hiding this comment.
umm i guess the current db pool before capella can be used as to recycle, i was going for caching any generic publishing errors but i guess its over kill
There was a problem hiding this comment.
the problem could be, once capella is hit, it would become unclear which ones are received from gossip and which ones have been submitted, as there is always a possibility of restarts while the gossip job is not complete, so would like to retain this as a separate repo
There was a problem hiding this comment.
we can clean it post capella
There was a problem hiding this comment.
It does not matter where an object is received. You persist to db changes that are still valid to be included in a block
There was a problem hiding this comment.
the problem could be, once capella is hit, it would become unclear which ones are received from gossip and which ones have been submitted
That's a fair point. However, it's not a consensus issue to re-broadcast other validator messages. After thinking about it I'm not opposed to mark those objects in some way as "submitted pre-capella"
dapplion
reviewed
Jan 23, 2023
| if (chain.clock.currentEpoch >= chain.config.CAPELLA_FORK_EPOCH) { | ||
| await network.gossip.publishBlsToExecutionChange(blsToExecutionChange); | ||
| } else { | ||
| await chain.cacheBlsToExecutionChanges(blsToExecutionChange); |
There was a problem hiding this comment.
Why is it necessary to explicitly call this? chain.opPool.insertBlsToExecutionChange should eventually write to DB on shutdown
dapplion
reviewed
Jan 23, 2023
| this.cachedBlsChangesPromise = this.gossipCachedBlsChanges().then(() => { | ||
| this.cachedBlsChangesPromise = null; | ||
| }); | ||
| } |
There was a problem hiding this comment.
Just move this code above under the // On fork transition comment, with some retry in case there are no peers
|
closing in favor of #5049 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user (most likely ) is expected to start submitting bls to execution changes earlier than capella hf . This would result in gossip error as the topic is not yet been subscribed by peers.
This PR would cache the bls changes and e re-gossip if there is any gossip publishing error.