Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethpanda images vs lodestar images #6943

Open
twoeths opened this issue Jul 11, 2024 · 2 comments
Open

ethpanda images vs lodestar images #6943

twoeths opened this issue Jul 11, 2024 · 2 comments
Labels
meta-bug Issues that identify a bug and require a fix. meta-investigate Issues found that require further investigation and may not have a specific resolution/fix

Comments

@twoeths
Copy link
Contributor

twoeths commented Jul 11, 2024

Describe the bug

Investigate why ethpanda images are usually have lower gc than lodestar images

with the same commit, on the mainnet node:

Screenshot 2024-07-11 at 09 29 01
  • while with lodestar image
Screenshot 2024-07-11 at 09 29 26

Expected behavior

should investigate how ethpanda create images, it'll likely save us ~100ms to ~150ms epoch transition due to lower gc

Steps to reproduce

No response

Additional context

No response

Operating system

Linux

Lodestar version or commit hash

v1.20.0

@twoeths twoeths added the meta-bug Issues that identify a bug and require a fix. label Jul 11, 2024
@ensi321
Copy link
Contributor

ensi321 commented Jul 11, 2024

ethpandaops/lodestar image is generated via two ways. Both are ran via GitHub actions in this repo:

  1. Manually trigger this action.
  2. Scheduled which runs every hour to check if new commits are pushed to Lodestar's unstable branch.

1 is mostly used for building images for devnet while 2 is for publishing up-to-date docker image periodically. The images in question are generated by 2.
They are running this script which I don't see anything special. Here's their arm64 and amd64 run log which could be something to investigate in. arm64 amd64

@philknows philknows added the meta-investigate Issues found that require further investigation and may not have a specific resolution/fix label Jul 11, 2024
@philknows philknows added this to the v1.21.0 milestone Jul 11, 2024
@philknows philknows removed this from the v1.21.0 milestone Aug 2, 2024
@nflaig
Copy link
Member

nflaig commented Aug 10, 2024

The only difference in their docker build is the setup of workflows as they use the same Dockerfile from Lodestar repo.

Notable differences are

  • they are not using QEMU and instead have two separate runners for amd64 / arm64 (see job run)
  • they are not using buildx initially to build / push images
  • but in case of a multi-platform image they combine existing images via docker buildx imagetools create (see manifest)

What's interesting, if you compare the ethpandaops image layers with the lodestar image layers they are exactly the same but somehow the WORKDIR command layer is 1 byte less in size. The total image size difference is 184.62 MB vs. 184.61 MB but dockerhub only shows 2 decimals so could be just the 1 byte difference.

Could it be that some native library is compiled differently on native runner compared to using QEMU? I don't see any other difference between those images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-bug Issues that identify a bug and require a fix. meta-investigate Issues found that require further investigation and may not have a specific resolution/fix
Projects
None yet
Development

No branches or pull requests

4 participants