fix: remove abortable iterator from muxer #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use an abortable source for every connection - this introduces a lot of latency. This PR removes abortable iterator to just listen on the abort event on the shutdown controller's abort signal and close the connection's iterator. This is the same thing that abortable source does except we don't race every `next` from the source. I've added a simple benchmark - in my testing it increases throughput by 30% or so, this seems to translate to 10-15% in "real world" performance using the `@libp2p/perf` testing protocol.
Codecov ReportAttention:
📢 Thoughts on this report? Let us know! |
wemeetagain
approved these changes
Nov 12, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 12, 2023
## [5.0.2](v5.0.1...v5.0.2) (2023-11-12) ### Bug Fixes * remove abortable iterator from muxer ([#63](#63)) ([064bf1c](064bf1c))
|
🎉 This PR is included in version 5.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use an abortable source for every connection - this introduces a lot of latency.
This PR removes abortable iterator to just listen on the abort event on the shutdown controller's abort signal and cause the connection's iterator to return.
This is the same thing that abortable source does except we don't
Promise.raceevery.next()from the source.I've added a simple benchmark - in my testing it increases throughput by 30% or so, this seems to translate to 10-15% in "real world" performance using the
@libp2p/perftesting protocol.