Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unhandle protocol on stop #438

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Conversation

wemeetagain
Copy link
Member

Resolves #437

Protocol handling has two components, registering inbound and outbound handlers.
It seems that on gossipsub.stop, we were unregistering the outbound handler but NOT properly unregistering the inbound handler.

@wemeetagain wemeetagain requested a review from a team as a code owner June 15, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unregister protocol on gossipsub.stop
2 participants