Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Config Setting): Updated DefaultMinPeers to 5 as per documentation #4252 #4259

Closed

Conversation

programmingwithrp
Copy link

Changes

According to the CLI documentation, DefaultMinPeers is 5 But in code it was 0. So Updated to 5 as per the documentation

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

#4252

@CLAassistant
Copy link

CLAassistant commented Oct 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.45%. Comparing base (d1ca7aa) to head (9187b81).
Report is 181 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #4259      +/-   ##
===============================================
+ Coverage        50.51%   53.45%   +2.93%     
===============================================
  Files              230      297      +67     
  Lines            29006    30634    +1628     
===============================================
+ Hits             14653    16374    +1721     
+ Misses           12856    12368     -488     
- Partials          1497     1892     +395     

@haikoschol
Copy link
Contributor

@programmingwithrp Thanks for your contribution! However, @raj921 had already opened #4252 which I just merged. Therefore I'm closing this PR.

@haikoschol haikoschol closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants