Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): update default min-peers value to 5 to match documentation #4257

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

raj921
Copy link
Contributor

@raj921 raj921 commented Oct 15, 2024

Changes

  • Updated the default value of the --min-peers flag to 5 in the code to align with the documented default.
  • Ensured consistency between the CLI documentation and actual implementation.

Tests

To verify the changes, you can run the integration tests:

go test -tags integration github.com/ChainSafe/gossamer

## Issues

Fixes: #4252

@CLAassistant
Copy link

CLAassistant commented Oct 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.52%. Comparing base (d1ca7aa) to head (5b2d7b0).
Report is 181 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #4257      +/-   ##
===============================================
+ Coverage        50.51%   53.52%   +3.01%     
===============================================
  Files              230      297      +67     
  Lines            29006    30634    +1628     
===============================================
+ Hits             14653    16398    +1745     
+ Misses           12856    12348     -508     
- Partials          1497     1888     +391     

@haikoschol
Copy link
Contributor

@raj921 Thanks for the contribution! Don't worry about the failing checks. Please sign the CLA and we'll merge this.

@raj921
Copy link
Contributor Author

raj921 commented Oct 15, 2024

sry for the delay sign in

Copy link
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

The --min-peers flag was documented to have a default value of 5, but the code had it set to 0. This commit changes the default value in the code to 5, aligning with the documentation and improving user experience.
@haikoschol haikoschol merged commit 97cd3d1 into ChainSafe:development Oct 16, 2024
22 of 25 checks passed
timwu20 added a commit that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants