refactor(pkg/trie/triedb): node level caching #4239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timwu20
force-pushed
the
tim/refactor-triedb-caching
branch
4 times, most recently
from
30419cd
to
941f91d
Compare
timwu20
requested review from
dimartiro,
EclesioMeloJunior and
jimjbrettj
as code owners
timwu20
force-pushed
the
tim/refactor-triedb-caching
branch
from
bea5ad3
to
1689aac
Compare
timwu20
force-pushed
the
tim/refactor-triedb
branch
from
dddbecc
to
1ffda9a
Compare
timwu20
force-pushed
the
tim/refactor-triedb-caching
branch
from
1689aac
to
2b1bc71
Compare
haikoschol
approved these changes
Oct 16, 2024
Co-authored-by: Haiko Schol <539509+haikoschol@users.noreply.github.com>
timwu20
force-pushed
the
tim/refactor-triedb-caching
branch
from
be0dd1e
to
3b7fb2f
Compare
EclesioMeloJunior
approved these changes
Oct 17, 2024
| var depth uint | ||
| for { | ||
| node, err := cache.GetOrInsertNode(hash, func() (CachedNode[H], error) { | ||
| prefixedKey := append(nibbleKey.Mid(keyNibbles).Left().JoinedBytes(), hash.Bytes()...) |
There was a problem hiding this comment.
I would suggest a comment here explaining how the prefix key is extracted from the nibbles
| for { | ||
| // Get node from DB | ||
| prefixedKey := append(nibbleKey.Mid(keyNibbles).Left().JoinedBytes(), hash.Bytes()...) |
There was a problem hiding this comment.
I would suggest a comment here explaining how the prefix key is extracted from the nibbles
dimartiro
approved these changes
Oct 18, 2024
| // TODO: we still have some room to improve here, we are caching the raw | ||
| // node data and we need to decode it every time we access it. We could | ||
| // cache the decoded node instead and avoid decoding it every time. | ||
| // This is the same as iterate_all_entries_without_cache since the raw iterator calls TrieDB.getNodeOrLookup | ||
| b.Run("iterate_all_entries_with_cache", func(b *testing.B) { |
There was a problem hiding this comment.
Is the iterator really using the cache? I'm getting the same results for this benchmark with / without the cache
Benchmark_NodesCache/iterate_all_entries_without_cache-12 24370 49277 ns/op 18688 B/op 2105 allocs/op
Benchmark_NodesCache/iterate_all_entries_with_cache-12 22998 49445 ns/op 18688 B/op 2105 allocs/op
I think you need to use the cache in the triedb.fetchValue method too
| @@ -24,7 +24,7 @@ type ( | |||
| // InlineNode contains bytes of the encoded node data | |||
| InlineNode []byte | |||
| // HashedNode contains a hash used to lookup in db for encoded node data | |||
| HashedNode[H any] struct{ Hash H } | |||
| HashedNode[H hash.Hash] struct{ Hash H } | |||
There was a problem hiding this comment.
Is there no issues when we are using prefixed keys here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
CachedNodeandCachedValuewhich is used in theTrieCacheinterface. These are analogous types tocodec.EncodedNodeandcodec.EncodedValue.CachedNodeAccessto the recorder and is recorded accordinglyTrieDBfunctions.TrieDB.GetHashandtriedb.GetWithfunctions that useTrieLookupwith supplied cache.Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
closes #4157