Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wasmer): remove duplicate logged functions #2666

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

qdm12
Copy link
Contributor

@qdm12 qdm12 commented Jul 12, 2022

Changes

  • Remove remaining function name prefixes in logs since the logger logs it already
  • Remove returned error value from ClearPrefix which is always nil

Tests

Issues

#2052

Primary Reviewer

@EclesioMeloJunior

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #2666 (a417030) into development (8fd2188) will increase coverage by 0.05%.
The diff coverage is 22.72%.

@@               Coverage Diff               @@
##           development    #2666      +/-   ##
===============================================
+ Coverage        62.96%   63.01%   +0.05%     
===============================================
  Files              211      211              
  Lines            27113    27132      +19     
===============================================
+ Hits             17071    17097      +26     
+ Misses            8482     8478       -4     
+ Partials          1560     1557       -3     
Flag Coverage Δ
unit-tests 63.01% <22.72%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/runtime/wasmer/imports.go 55.53% <19.04%> (+0.26%) ⬆️
lib/runtime/storage/trie.go 53.61% <100.00%> (-0.28%) ⬇️
lib/babe/verify.go 88.88% <0.00%> (-2.35%) ⬇️
dot/network/utils.go 58.33% <0.00%> (-1.93%) ⬇️
dot/sync/message.go 66.21% <0.00%> (-0.68%) ⬇️
dot/types/babe.go 34.72% <0.00%> (ø)
dot/network/notifications.go 66.32% <0.00%> (+1.03%) ⬆️
lib/blocktree/blocktree.go 54.71% <0.00%> (+1.08%) ⬆️
dot/network/connmgr.go 90.41% <0.00%> (+1.36%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fd2188...a417030. Read the comment docs.

@qdm12 qdm12 marked this pull request as ready for review July 12, 2022 17:13
Copy link
Member

@EclesioMeloJunior EclesioMeloJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qdm12 qdm12 merged commit cb1da40 into development Jul 26, 2022
@qdm12 qdm12 deleted the qdm12/wasmer/remove-logs branch July 26, 2022 20:25
@github-actions
Copy link

🎉 This PR is included in version 0.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants