chore(lib/runtime/wasmer): import functions in a for loop

[qdm12]

Changes

• ImportsNodeRuntime: append functions in a for loop
• ImportsNodeRuntime: remove no longer needed //nolint:gocyclo
• ImportsNodeRuntime: update now deprecated .Append to be .AppendFunction
• ImportsNodeRuntime: sort import appending alphabetically

Tests

Issues

Done whilst adding functions

Primary Reviewer

@kishansagathiya

[codecov]

Codecov Report

Merging #2650 (14a0f83) into development (d2da7fb) will increase coverage by 0.58%.
The diff coverage is 96.87%.

@@               Coverage Diff               @@
##           development    #2650      +/-   ##
===============================================
+ Coverage        62.34%   62.93%   +0.58%     
===============================================
  Files              211      211              
  Lines            27343    27106     -237     
===============================================
+ Hits             17048    17059      +11     
+ Misses            8654     8486     -168     
+ Partials          1641     1561      -80     

Flag	Coverage Δ
unit-tests	62.93% <96.87%> (+0.58%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
lib/runtime/wasmer/imports.go	55.03% <96.87%> (+6.88%)	⬆️
dot/network/inbound.go	92.98% <0.00%> (-7.02%)	⬇️
dot/network/block_announce.go	58.40% <0.00%> (-4.81%)	⬇️
dot/network/service.go	56.74% <0.00%> (-0.27%)	⬇️
dot/network/sync.go	5.26% <0.00%> (ø)
dot/network/utils.go	58.33% <0.00%> (ø)
dot/network/notifications.go	65.29% <0.00%> (+0.11%)	⬆️
lib/grandpa/network.go	47.79% <0.00%> (+0.38%)	⬆️
lib/blocktree/blocktree.go	54.71% <0.00%> (+1.08%)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2da7fb...14a0f83. Read the comment docs.

[EclesioMeloJunior]

Would be more clear to have this as a fixed-sized array outside of the function scope IMO

var importedFuncs = [...]struct{
  import_name string
  implementation interface{}
  cgoPointer     unsafe.Pointer
}{
    ...
}

for _, toRegister := importedFuncs {
    _, err = imports.AppendFunction(toRegister.importName, toRegister.implementation, toRegister.cgoPointer)
    if err != nil {
        return nil, fmt.Errorf("importing function: %w", err)
    }
}

[qdm12]

Definitely taking the fixed size array (god damn second time I don't use it, thanks for the reminder!).
Although I don't really see the point to have it at global scope 🤔 I don't think it would change performance wise, and it's only used in that function. It would also pollute more the (unexported) package Go API.

Keep in mind I'm a very pro-local-everything-activist

[github-actions]

🎉 This PR is included in version 0.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀