-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(trie): proof code refactoring and fixes #2604
Merged
Merged
Commits on Jul 4, 2022
-
- `lib/trie` proof files - `internal/trie/record` package
Configuration menu - View commit details
-
Copy full SHA for 47e2d0b - Browse repository at this point
Copy the full SHA 47e2d0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 50e221e - Browse repository at this point
Copy the full SHA 50e221eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f641cb4 - Browse repository at this point
Copy the full SHA f641cb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f93b54c - Browse repository at this point
Copy the full SHA f93b54cView commit details -
- Only verify for a single key and value - Produce ordered proof encoded nodes from root to leaves - Node deduplication logic removed (now unneeded) - Remove recorder code (now unneeded) - Generate uses a `Database` smaller interface - Better error wrapping - Error when key is not found in trie when generating proof - Generate only generates proof encoded nodes for a single given key
Configuration menu - View commit details
-
Copy full SHA for e5dc44e - Browse repository at this point
Copy the full SHA e5dc44eView commit details -
Move proof trie build functions to
internal/trie/proof
- `buildTrie` returns a `*trie.Trie` - `loadProof` only acts on a parent node pointer - Older `LoadFromProof` and `loadProof` functions removed from `trie/database.go`
Configuration menu - View commit details
-
Copy full SHA for 90d2546 - Browse repository at this point
Copy the full SHA 90d2546View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7285e16 - Browse repository at this point
Copy the full SHA 7285e16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31ccd8e - Browse repository at this point
Copy the full SHA 31ccd8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6882bb6 - Browse repository at this point
Copy the full SHA 6882bb6View commit details -
- More context to error wrapping - Verify function only returns an error
Configuration menu - View commit details
-
Copy full SHA for ce04e19 - Browse repository at this point
Copy the full SHA ce04e19View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8d88b4 - Browse repository at this point
Copy the full SHA e8d88b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b64e74b - Browse repository at this point
Copy the full SHA b64e74bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5b33c2 - Browse repository at this point
Copy the full SHA b5b33c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c89af8 - Browse repository at this point
Copy the full SHA 2c89af8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea84414 - Browse repository at this point
Copy the full SHA ea84414View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee988d5 - Browse repository at this point
Copy the full SHA ee988d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for da0c760 - Browse repository at this point
Copy the full SHA da0c760View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84b5a57 - Browse repository at this point
Copy the full SHA 84b5a57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a5bb95 - Browse repository at this point
Copy the full SHA 9a5bb95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f70103 - Browse repository at this point
Copy the full SHA 9f70103View commit details -
- `proofHashToNode` to `merkleValueToNode` - `proofHash` to `merkleValue`
Configuration menu - View commit details
-
Copy full SHA for 99541b9 - Browse repository at this point
Copy the full SHA 99541b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69cd49f - Browse repository at this point
Copy the full SHA 69cd49fView commit details -
Generate
generates deduplicated encoded proof nodes for N full keys- Load trie only once from database - Move StorageState `GenerateTrieProof` to `lib/trie/proof` package - Update tests
Configuration menu - View commit details
-
Copy full SHA for 53e4a64 - Browse repository at this point
Copy the full SHA 53e4a64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25b4e57 - Browse repository at this point
Copy the full SHA 25b4e57View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.