Remove checks for equivocatory blocks #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d8e422c.
created by primary block producer
kishansagathiya
requested review from
noot,
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj and
qdm12
as code owners
EclesioMeloJunior
requested changes
Jun 17, 2022
Codecov Report
@@ Coverage Diff @@
## development #2596 +/- ##
===============================================
+ Coverage 62.44% 62.99% +0.54%
===============================================
Files 211 211
Lines 27354 27136 -218
===============================================
+ Hits 17082 17095 +13
+ Misses 8633 8482 -151
+ Partials 1639 1559 -80
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
EclesioMeloJunior
requested changes
Jun 29, 2022
edwardmack
approved these changes
Jun 29, 2022
Co-authored-by: Eclésio Junior <eclesiomelo.1@gmail.com>
…/gossamer into kishan/fix/equivocatory-blocks
EclesioMeloJunior
requested changes
Jul 4, 2022
EclesioMeloJunior
requested changes
Jul 6, 2022
timwu20
reviewed
Jul 6, 2022
Co-authored-by: Timothy Wu <timwu20@gmail.com>
…/gossamer into kishan/fix/equivocatory-blocks
EclesioMeloJunior
requested changes
Jul 7, 2022
EclesioMeloJunior
approved these changes
Jul 11, 2022
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We have logic to find different blocks with same block number and same author. If we find such blocks we throw and error.
Some of the discussion is here #2541 (comment)
#2541 (comment)
As discussed with @noot , it's probably authoring one as primary and one as secondary. If we don't error the fork should get resolved eventually.
Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
Fixes #2597
Primary Reviewer
@timwu20