Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dot/network): remove secio support from libp2p host #1908

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

kishansagathiya
Copy link
Contributor

@kishansagathiya kishansagathiya commented Oct 19, 2021

Changes

  • Removes secio support from libp2p host

Tests

  • Run ./bin/gossamer --chain polkadot and check if it can import blocks and sync.

Issues

Primary Reviewer

Copy link
Contributor

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #1908 (3c31cf9) into development (2186caf) will decrease coverage by 0.03%.
The diff coverage is 46.15%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1908      +/-   ##
===============================================
- Coverage        59.73%   59.69%   -0.04%     
===============================================
  Files              187      188       +1     
  Lines            19119    19131      +12     
===============================================
+ Hits             11420    11421       +1     
- Misses            5825     5833       +8     
- Partials          1874     1877       +3     
Flag Coverage Δ
unit-tests 59.69% <46.15%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dot/network/host.go 65.51% <ø> (-0.20%) ⬇️
dot/telemetry/prepared_block_for_proposing.go 0.00% <0.00%> (ø)
lib/babe/babe.go 51.04% <75.00%> (+0.68%) ⬆️
dot/network/service.go 69.27% <0.00%> (-1.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb4a529...3c31cf9. Read the comment docs.

@EclesioMeloJunior
Copy link
Member

I guess you just need to adjust the PR name

@kishansagathiya kishansagathiya changed the title Remove secio support from libp2p host chore(dot/network): remove secio support from libp2p host Oct 21, 2021
go.sum Show resolved Hide resolved
@noot noot merged commit b7da83b into ChainSafe:development Oct 25, 2021
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

timwu20 pushed a commit to timwu20/gossamer that referenced this pull request Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dot/network: deprecate secio
5 participants