-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Integrate scale package into lib/trie #1804
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1804 +/- ##
===============================================
- Coverage 59.57% 59.51% -0.07%
===============================================
Files 187 186 -1
Lines 19782 19724 -58
===============================================
- Hits 11785 11738 -47
+ Misses 5983 5982 -1
+ Partials 2014 2004 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
3c60752
to
3b4fb18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work, lgtm.
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
* remove unused Encode/Decode * update scale integration * newHasher
Changes
lib/trie/Hasher
to become privateTests
Issues
Primary Reviewer