Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track GRANDPA Changes Across Forks #2348

Closed
danforbes opened this issue Mar 4, 2022 · 1 comment
Closed

Track GRANDPA Changes Across Forks #2348

danforbes opened this issue Mar 4, 2022 · 1 comment
Assignees
@EclesioMeloJunior

Comments

@danforbes
Copy link
Contributor

danforbes commented Mar 4, 2022 •
edited
Loading

Similar to #2269. GRANDPA changes are not undone if there's a fork. This could cause consensus issues for functions like handleScheduledChange() and handleForcedChange() and handleGrandpaChangesOnImport() if different changes are scheduled in the forks then we will either error or return nil for the second block that is processed. In Substrate they use a ForkTree for the schedule changes and a Vec for the forced changes as seen in this struct from substrate/client/finality-grandpa/src/authorities.rs.
@danforbes danforbes changed the title Track GRANDPA Scheduled Changes Across Forks Track GRANDPA Changes Across Forks Mar 7, 2022
@noot noot mentioned this issue Mar 17, 2022
Closed
@danforbes
Copy link
Contributor Author

Duplicate of #2400

@danforbes danforbes marked this as a duplicate of #2400 Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EclesioMeloJunior EclesioMeloJunior

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danforbes @EclesioMeloJunior