Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BABE NextEpochData and NextConfigData should be set on finalization, not import (GSR-01) #2269

Closed
noot opened this issue Feb 4, 2022 · 0 comments · Fixed by #2339
Closed

BABE NextEpochData and NextConfigData should be set on finalization, not import (GSR-01) #2269

noot opened this issue Feb 4, 2022 · 0 comments · Fixed by #2339
Assignees
@EclesioMeloJunior

Comments

@noot
Copy link
Contributor

noot commented Feb 4, 2022

Task summary

  • currently, BABE NextEpochData and NextConfigData are set on import of a block containing them (first block in an epoch)
  • however, there is a chance there are two conflicting blocks that both contain these digests. these digests should be set in the database when the block is finalized, not when it's imported, to prevent us from using upcoming BABE data from a dropped fork.
@EclesioMeloJunior EclesioMeloJunior self-assigned this Feb 8, 2022
@danforbes danforbes mentioned this issue Feb 17, 2022
Closed
@EclesioMeloJunior EclesioMeloJunior mentioned this issue Mar 2, 2022
Merged
@danforbes danforbes mentioned this issue Mar 4, 2022
Closed
@danforbes danforbes mentioned this issue Mar 18, 2022
Closed
@danforbes danforbes changed the title BABE NextEpochData and NextConfigData should be set on finalization, not import BABE NextEpochData and NextConfigData should be set on finalization, not import (GSR-01) Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EclesioMeloJunior EclesioMeloJunior

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@danforbes @EclesioMeloJunior @noot