Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE flag logic for Origin needs improving #88

Open
DanyC97 opened this issue Jun 17, 2018 · 0 comments
Open

BE flag logic for Origin needs improving #88

DanyC97 opened this issue Jun 17, 2018 · 0 comments
Assignees

Comments

@DanyC97
Copy link
Contributor

DanyC97 commented Jun 17, 2018

Writing it down before i forget ..
currently when BE flag is enabled we do the following:

  • Jenkins job set the ORIGIN_VERSION to default value
    • default value is static and needs to be changed everytime upstream is being changed. This logic is a catch 22 since someone needs to always be ahead / up to date with upstream so we can get the job working (which runs every 3 h)
  • we clone master origin branch
  • we set ORIGIN_VERSION default value passed in in the origin.spec file
  • tito builds the rpm with the modified rpm
  • cbs is pushing the rpm however that fails - see here since the rpm is origin-3.10.0-0.alpha.0.el7.git.0.af33468.src.rpm but in the build.log we can see it detects a different OS_GIT_VERSION=v3.11.0-alpha.0+af33468-8 . That is because we passed something else [1]

[1]
" Fixup spec file - v3.10.0-alpha.0", "", "diff --git a/origin.spec b/origin.spec", "index 49b7bf8..0816950 100644", "--- a/origin.spec", "+++ b/origin.spec", "@@ -65,8 +65,8 @@", " %{!?release: %global release 1}", " ", " Name: %{package_name}", "-Version: %{version}", "-Release: %{release}%{package_dist}", "+Version: 3.10.0", "+Release: 0.alpha.0%{dist}", " Summary: Open Source Container Management by Red Hat", " License: ASL 2.0", " URL: https://%{import_path}" ]

@DanyC97 DanyC97 self-assigned this Jun 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant