Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is OVERRIDE_PV_CONFIG_WITH_IMAGE_CONFIG intended? #19

Open
johnbieren opened this issue Dec 12, 2018 · 1 comment
Open

Is OVERRIDE_PV_CONFIG_WITH_IMAGE_CONFIG intended? #19

johnbieren opened this issue Dec 12, 2018 · 1 comment

Comments

@johnbieren
Copy link

In the Jenkins master s2i...
https://github.com/CentOS-PaaS-SIG/contra-env-infra/blob/master/jenkins/master/s2i/jenkins-persistent-template.yml#L162
Just wondering if this was intended or just some copy paste code, as it causes all previous data in /var/lib/jenkins to be lost whenever the master restarts. If there is not an argument for it, I'd say we can probably remove it, but if there is a reason to have it, that is fine.
@joejstuart
Copy link
Contributor

Good question. Having persistent in the filename makes it confusing at the least. I'll take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnbieren @joejstuart