Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user i can create or edit a skill #39

Open
7 tasks done
utunga opened this issue Mar 4, 2022 · 8 comments
Open
7 tasks done

As a user i can create or edit a skill #39

utunga opened this issue Mar 4, 2022 · 8 comments
Assignees

Comments

@utunga
Copy link
Contributor

utunga commented Mar 4, 2022

Acceptance criteria

  • User can enter title, desciption and hit save and these things are saved
  • If the user types a 'hashtag' (#) in the text area it adds to the 'hashtags section'
  • If the user clicks '+ add tag' it creates a way where they can add a hashtag
  • If the user clicks on a hashtag it deletes the hashtag (not exactly sure the best way to handle this vis-a-vis text)
  • When the user saves a skill it checks that all hashtags already exist in the hashtag table and if not there adds them
  • User can hit cancel and go back to my skills section (equivalent of swiping back)
  • No navigation visible at bottom in this page

Discussion

When the user deletes from the list of hashtags should it remove from the text?

Mockup

image

@utunga utunga changed the title As a user i can add/edit a skill As a user i can create or edit a skill Mar 4, 2022
@mjxchina mjxchina self-assigned this Mar 9, 2022
@utunga
Copy link
Contributor Author

utunga commented Mar 9, 2022

Turns out I have some strongish opinions on how to do the tagging interface - these are informed by a couple of longer term objectives:

  • Desire to move to an ssb (scuttlebutt.nz) back end at some point (for decentralization purposes)
  • Desire to build integration points to ingest messages posted originally on existing social media (meaning being able to parse a message posted originally on twitter, say, and then ingest and interpret it as a message inside of our system)

With that in mind I'd like to do the following - I think it resolves the UX questions about tagging, teaches people how tags work elsewhere in this app, and also is consistent with the above two things.

  • Just make it a rule that every hashtag that appears in the list of hashtags also has to appear as plain text in the message itself (preceded by a '#' symbol)

  • Let's define the text in the description window as 'the text'.

  • If a user types "#" in the main description window, no need for fancy pop-over effects just yet

  • If you they type #asomething then that hashtag appears in the list of hashtagss

  • If they then delete it from the list of hashtags it also removes from the text

  • If they click 'add hashtag' some sort of popup or drop-down or chooser of some kind appears that lets them pick from suggested hashtags *

  • When the add a hashtag to the list of hashtags append a " #hashtag" to the end of the text (with a space at the start). This will create a list of hashtags at the end of the text (which is a common enough pattern) but, note that it is also possible to add a hashtag to the text (and have it appear in the list) by typing it in manually anywhere else in the text

  • If they type a hashtag twice or more have it appear twice in both places (twice in the text and twice in the list) - removing one (from either place) removes just one from the other place

  • it needs to be possible, when you first arrive to just click in the desccirption field and start typing.. but already have at least one hashtag that you are applying.. for this reason no matter where someone clicks in the text area at the beginning create a text field where their cursor appears at left most edge - of the text " #advice", say, (if 'advice' was the hashtag)

@utunga
Copy link
Contributor Author

utunga commented Mar 9, 2022

Also..

  • clicking a hashtag should remove it - this is good training for the search/filter pages where clicking hashtag will do the same thing.. we may need to add a small x next to the hashtag to symbolize the fact ..

Maybe a bit like the one on the 'font awesome' search page ..

image

@utunga
Copy link
Contributor Author

utunga commented Mar 9, 2022

So new plan

If the user clicks 'add tag' the following happens

  • The text " #" is added to the text field
  • The cursor / focus moves to the end of the text field (and keyboard activated) so they can start typing
  • The dropdown of possible hashtag matches appears
  • The hashtag as it is typed is highlighted

Something like this

image

  • If they click away no hash tag is added
  • If they choose a hashtag from the list it is inserted and appears in both places

@utunga
Copy link
Contributor Author

utunga commented Mar 9, 2022

  • Also if they type " #" in the text area the chooser also pops up - same as above

@utunga
Copy link
Contributor Author

utunga commented Mar 9, 2022

In the chooser

  • Display icon if it exists *otherwise blank)
  • Display a count of number of uses in requests
  • Sort by # requests (in all time)

@utunga
Copy link
Contributor Author

utunga commented Mar 9, 2022

To clarify adding or editing a skill should be the whole screen with no 'add skill' button at top.. you can swipe back or click cancel to get back to their skills section and then add a skill from there...

@utunga
Copy link
Contributor Author

utunga commented Mar 11, 2022

  1. filter by text typed (or just from all if they havent typed any letters)
  2. sort by count of uses in requests descending, then by blessed (blessed at top) then by alpha
  3. let the user scroll from 12 total

@utunga
Copy link
Contributor Author

utunga commented Mar 16, 2022

Feedback:

  • When typing a hashtag - if it has an associated icon - it should show in the typeahead, if not leave a blank space (so they line up correctly)

  • instead of showing 'blessed' with a heart - maybe just bold those ones

  • after you hit save it should close and take you 'back'..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants