Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You should be able to edit your data in this mode #152

Closed
xavijam opened this issue May 14, 2013 · 21 comments · Fixed by #3812
Closed

You should be able to edit your data in this mode #152

xavijam opened this issue May 14, 2013 · 21 comments · Fixed by #3812
Assignees
Milestone

Comments

@xavijam
Copy link
Contributor

xavijam commented May 14, 2013

JIRA ref: https://cartodb.atlassian.net/browse/CDB-238

@ghost ghost assigned javierarce and javisantana May 14, 2013
@xavijam
Copy link
Contributor Author

xavijam commented May 14, 2013

cc @javierarce

@gouldingken
Copy link

It appears that 'Filter mode' is basically just modifying the SQL query. Could you make a special case to enable editing for all queries which start with "SELECT * from current_carto_db_table".

@strk
Copy link

strk commented Sep 11, 2013

Is this still an issue ? Last update was 4 months ago

@saleiva
Copy link
Contributor

saleiva commented Sep 11, 2013

Yeah. In afraid yes. Can someone take a look if its on JIRA? I cannot check it now

Sent from my iPhone

On 11/09/2013, at 13:23, strk notifications@github.com wrote:

Is this still an issue ? Last update was 4 months ago


Reply to this email directly or view it on GitHub.

@javisantana
Copy link
Contributor

it's already open

@strk
Copy link

strk commented Sep 11, 2013

@saleiva saleiva changed the title [FILTER] You should be able to edit your data in this mode You should be able to edit your data in this mode Oct 29, 2014
@iriberri
Copy link
Contributor

Hey, one year and 1000 tickets after this, let's solve it! :) @Xatpy

@Xatpy
Copy link
Contributor

Xatpy commented Dec 18, 2014

Yes! It is being requested from support:

If a query/filter is applied to the table, the listing are no longer editable. Is there an out-of-the-box solution for searching for a listing and then editing in CartoDB? Any suggestions that I could pass on to my clients?

@gagecarto
Copy link

I'd love to see this feature! CartoDB rocks!

@Xatpy
Copy link
Contributor

Xatpy commented Jan 8, 2015

We have just received another ticket about it (SB / 3432212).

@pkej
Copy link

pkej commented Jan 8, 2015

Hi,
I guess it is my support ticket you refer to, Xatpy. I'd like to stress that we have 48 000+ long table, which is just for one of three territories which are of interest for us, I'm awaiting a doubling of our database when it comes to names, though I might prune it for non-Sami-language place names.

@iriberri
Copy link
Contributor

One more time, we've just been asked about this again. 😄

@iriberri
Copy link
Contributor

One more time! @saleiva push? :)

@ztephm
Copy link

ztephm commented May 26, 2015

Hi, another user asking for this, S/B: 5454984
cc @jsantana

@iriberri
Copy link
Contributor

@javisantana what do you think?

@alonsogarciapablo
Copy link
Contributor

There's something that still needs to be done. This how it's working right now:

edit_while_filtering

As a result of this, the UI is a bit inconsistent because the filters haven't been refreshed/updated and we're still seeing a row that shouldn't be there according to the filters. I think a good solution would be to update the filters so that it shows the new value and "enable" it so that the row is not removed from the table.

@saleiva
Copy link
Contributor

saleiva commented May 28, 2015

+1

@xavijam
Copy link
Contributor Author

xavijam commented May 28, 2015

Agree

@iriberri
Copy link
Contributor

Mola, and 👍

@alonsogarciapablo
Copy link
Contributor

This is now working very good with discrete filters (on string columns):

filters

I found a problem with regular filters (numbers and columns) and I'm working on fixing that now.

@xavijam
Copy link
Contributor Author

xavijam commented Jun 3, 2015

Super duper!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.