Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that torch SVD returns eigenvalues in sort order #269

Open
charlesmartin14 opened this issue Jun 23, 2023 · 1 comment
Open

Check that torch SVD returns eigenvalues in sort order #269

charlesmartin14 opened this issue Jun 23, 2023 · 1 comment

Comments

@charlesmartin14
Copy link
Member

Accordiong to ChatGPT

As of my knowledge cutoff in September 2021, PyTorch's SVD implementation had some limitations. It uses a batched SVD routine, which can cause problems with larger matrices due to GPU memory limitations. PyTorch's SVD also may return singular values that are not sorted, which is non-standard behavior that can surprise users.

@charlesmartin14
Copy link
Member Author

also

On the other hand, CuPy uses a more standard, non-batched routine for SVD, which is less likely to run into memory issues for large matrices. Also, CuPy's SVD returns singular values in descending order, which is the typical behavior expected by users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant