Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file-access errors with newest NetCDF4, adjust testing default settings #267

Merged
merged 7 commits into from
Mar 7, 2023

Conversation

Zeitsperre
Copy link
Member

No description provided.

@Zeitsperre Zeitsperre added the bug Something isn't working label Mar 6, 2023
@Zeitsperre Zeitsperre requested a review from huard March 6, 2023 20:35
@Zeitsperre Zeitsperre self-assigned this Mar 6, 2023
@Zeitsperre
Copy link
Member Author

I've been running into an issue like this one: Unidata/netcdf4-python#1205. Hopefully, the workaround of ensuring that files are closed properly will address this?

@coveralls
Copy link

coveralls commented Mar 7, 2023

Pull Request Test Coverage Report for Build 4357323692

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.263%

Totals Coverage Status
Change from base Build 4346800770: 0%
Covered Lines: 3748
Relevant Lines: 4448

💛 - Coveralls

…" pytest-xdist scheduler, add RAVENPY_TESTDATA_BRANCH and RAVENPY_SKIP_TEST_DATA env vars, pass RAVENPY env vars to tox, adjust CI
@Zeitsperre Zeitsperre changed the title Fix file-access errors with newest NetCDF4 Fix file-access errors with newest NetCDF4, adjust testing default settings Mar 7, 2023
@Zeitsperre
Copy link
Member Author

@huard

I decided to throw in the testing adjustments so that individual tests do not create multiple workers. Similar to changes in Ouranosinc/xclim@b69b867, we now have pytest-xdist disabled when running pytest and enabled when running tox.

I also modified the env vars:

  • MAIN_TESTDATA_BRANCH --> RAVENPY_TESTDATA_BRANCH
  • SKIP_TEST_DATA --> RAVENPY_SKIP_TEST_DATA

These env vars can be set in the main CI workflow.

@Zeitsperre Zeitsperre merged commit 5c6bf66 into master Mar 7, 2023
@Zeitsperre Zeitsperre deleted the fix-conda-netcdf branch March 7, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants