OAuth improvements and new status codes #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new libbi status codes
Added graceful OAuth handling to libbi
added --skip-oauth flag to cli
|
I also added a "--skip-oauth" flag to the cli, so it doesn't ask for app email/password (for users without libbi) |
|
@CJNE Apologies for the tag, but do you think you could review this PR? The HA integration PR depends on this one. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds further functionality that's related to the libbi. The main change is to return 'None' as property values when OAuth is required, but no credentials are defined. The HA integration uses these None values to display entities as unavailable if OAuth is missing.
The PR adds a few new libbi status codes.
Also fixed a couple of linting errors.