Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle num_phases correctly, can be 1, 3, or auto, see #28 #35

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Handle num_phases correctly, can be 1, 3, or auto, see #28 #35

merged 2 commits into from
Jun 3, 2024

Conversation

jwillemsen
Copy link
Contributor 

* pymyenergi/zappi.py:

@jwillemsen
Copy link
Contributor Author

jwillemsen commented Apr 25, 2024 •
edited
Loading

Implements #28

@jwillemsen
Implement set_phase_setting
4542beb 
    * pymyenergi/zappi.py:
@jwillemsen jwillemsen mentioned this pull request May 13, 2024
Merged
CJNE
CJNE approved these changes Jun 3, 2024
View reviewed changes
Copy link
Owner

@CJNE CJNE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@CJNE CJNE merged commit fcf1da0 into CJNE:main Jun 3, 2024
0 of 2 checks passed
@jwillemsen jwillemsen deleted the jwi-numphases2 branch June 3, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CJNE CJNE CJNE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwillemsen @CJNE