Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Narwhal Port #776

Merged
merged 5 commits into from
Oct 20, 2022
Merged

Update Narwhal Port #776

merged 5 commits into from
Oct 20, 2022

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Oct 18, 2022

PR checklist

  • Short (1 sentence) summary of your PR:
    Update Narwhal port, add narwhal_intelhpcx

  • Developer(s):
    apcraig

  • Suggest PR reviewers from list in the column to the right.

  • Please copy the PR test results link or provide a summary of testing completed below.
    All results pass, regression testing not done due to lack of baseline on Narwhal.

  • How much do the PR code changes differ from the unmodified code?

    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?

    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.

    • Yes
    • No
  • Does this PR add any new test cases?

    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)

    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

  • Update narwhal modules

  • Add narwhal_intelhpcx

  • Change ICE_MACHINE to ICE_MACHCOMP in cice.launch.csh to provide greater flexibility

  • Add debug output on abort in ice_domain

@apcraig apcraig merged commit db2d7a9 into CICE-Consortium:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants