Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor modifs to ice_dyn routines #158

Merged

Conversation

JFLemieux73
Copy link
Contributor

-Renamed evp_prep1 and 2 to dyn_prep1 and 2.

-Renamed evp_finish to dyn_finish

-Added OMP instruction for basal_stress calculation

-Changed the order of Deltasw and Deltase so that these deformations are calculated in the same order as the other ones (i.e., ne-nw-sw-se).

  • Developer(s): JF Lemieux

  • Please suggest code Pull Request reviewers in the column at right.

  • Are the code changes bit for bit, different at roundoff level, or more substantial? BFB

  • Is the documentation being updated with this PR? (Y/N) Y
    If not, does the documentation need to be updated separately at a later time? (Y/N)
    Note: "Documentation" includes information on the wiki and .rst files in doc/source/,
    which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.

  • Other Relevant Details:

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all fine.
Too bad you took out the French!

@eclare108213 eclare108213 merged commit 8b44ba1 into CICE-Consortium:master Jul 9, 2018
@JFLemieux73 JFLemieux73 deleted the MinorModif_4july2018 branch January 26, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants