Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add byteswapio to LDFLAGS for CCE #120

Merged
merged 1 commit into from
Apr 5, 2018

Conversation

mattdturner
Copy link
Contributor

Add the -h byteswapio flag to LDFLAGS for all Macros.*_cray files.

  • Developer(s): Matt Turner

  • Please suggest code Pull Request reviewers in the column at right.

  • Are the code changes bit for bit, different at roundoff level, or more substantial? More substantial, but this fixes a bug that caused runs with CCE to not complete

  • Is the documentation being updated with this PR? (Y/N) N
    If not, does the documentation need to be updated separately at a later time? (Y/N) N
    Note: "Documentation" includes information on the wiki and .rst files in doc/source/,
    which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.

  • Other Relevant Details:
    This addresses Crashes when using CCE #119
    The Macros.*_cray files had -h byteswapio in FFLAGS, but not in LDFLAGS. However, according to the Cray documentation "[b]yteswapio is implemented during the linker phase so that it can be uniformly applied across the entire executable", so -h byteswapio has to be included in LDFLAGS.

@apcraig apcraig self-requested a review April 5, 2018 18:25
Copy link
Contributor

@apcraig apcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matt! Will merge once the travis tests are complete.

@apcraig apcraig merged commit f9117aa into CICE-Consortium:master Apr 5, 2018
@mattdturner mattdturner deleted the CCE_bugfix branch May 29, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants