Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch_last_solo_match/2 not guaranteed to return match from current season #57

Open
ecly opened this issue Feb 22, 2018 · 0 comments
Open

Comments

@ecly
Copy link
Member

ecly commented Feb 22, 2018

Queries for last solo queue match seem to be able to return games from last season, causing us to show potentially wrong results for border. This occurs in fetch_last_solo_match/2 in riot.api.ex, and is a somewhat special case bug.

This is currently only a problem for us early in a season, as we require players to have a match history from which we can deduce their last played champions and/or their border. If they have a match history, and their last solo queue game was from the last season, we will get a rank indication from 2 seasons ago.

Potential fixes:

  • Query API for season specific match
    • Requires some consistent way of getting current season id
    • (Riot currently has bug with bad season id's for matches making this inconsistent)

...

@ecly ecly added the wontfix label Feb 22, 2018
@ecly ecly added the bug label Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant